Bug 1481957 - Recent connections is empty
Summary: Recent connections is empty
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-viewer
Version: unspecified
Hardware: x86_64
OS: Windows
unspecified
high
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact:
URL:
Whiteboard:
: 1253915 1610564 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-16 07:09 UTC by admin
Modified: 2022-10-16 15:56 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description admin 2017-08-16 07:09:25 UTC
Description of problem:


Version-Release number of selected component (if applicable): 6.0-256 x64


How reproducible:


Steps to Reproduce:
1. Open Virt Viewer
2. Connect to remote virtual machine
2. Close connection
3. Open Virt Viewer 

Actual results:
Open window, but the Recent connections Window is empty

Expected results:
Recent connections Window must include the url connections to the remote machine

Additional info:

Comment 1 Daniel Berrangé 2019-03-21 15:38:12 UTC
*** Bug 1610564 has been marked as a duplicate of this bug. ***

Comment 2 Daniel Berrangé 2019-03-21 15:42:16 UTC
I can see that this works on Linux, but has stopped working on Windows. AFAIK this is supposed to be handled automatically for us by GtkRecentChooser so presumably something in GTK has broken this.

Comment 3 Daniel Berrangé 2019-03-22 11:16:23 UTC
*** Bug 1253915 has been marked as a duplicate of this bug. ***

Comment 4 Daniel Berrangé 2019-03-22 11:18:08 UTC
The original Windows MSI installer for virt-viewer 5.0 *does* remember connections, but if I build a new MSI installer for the 5.0 release it does *NOT* remember connections. This strongly suggests the problem is not in virt-viewer, but instead most likely a regression in GTK

Comment 5 Daniel Berrangé 2019-03-22 11:53:20 UTC
It was broken somewhere between GTK 3.22.2 and 3.22.17  AFAIK.

A likely candidate is the refactoring work done to support GContentType on non-Linux:

  https://bugzilla.gnome.org/show_bug.cgi?id=734946

This included changes to filter the recent files list in:

commit e387f807e4a6da663bca3f8d0b75f1cdbd66465d
Author: TingPing <tingping>
Date:   Wed Mar 8 22:52:58 2017 -0500

    Improve GContentType usage
    
    Convert to content type where needed.
    Should fix various issues on Windows and OS X.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734946


I'm guessing our saved URIs get filtered out as there is no content type match for the vnc:// and spice:// URI schemes.

Comment 6 Daniel Berrangé 2019-03-22 11:56:34 UTC
Added Marc-Andre who recent the original "recent connections" code in case he has any ideas on fixing this.

Comment 7 Marc-Andre Lureau 2019-03-22 19:11:06 UTC
(In reply to Daniel Berrange from comment #6)
> Added Marc-Andre who recent the original "recent connections" code in case
> he has any ideas on fixing this.

Yep, after some investigations:
https://gitlab.gnome.org/GNOME/gtk/issues/1769

Comment 8 Daniel Berrangé 2019-03-25 11:02:34 UTC
I wonder if the suggestion in this bug for registering the URI schemes would avoid us triggering the GTK bug

https://bugzilla.redhat.com/show_bug.cgi?id=1434368

Comment 9 Aaron 2022-05-23 15:07:02 UTC
this stupid bug last so looooooog years

Comment 10 Dave May 2022-10-16 15:56:25 UTC
Yep, five years without a fix. What's the justification for a MIME type lookup anyway? GTK blames applications that do this for the failed behavior.


Note You need to log in before you can comment on or make changes to this bug.