Bug 1482023 - snpashots issues with other processes accessing the mounted brick snapshots
Summary: snpashots issues with other processes accessing the mounted brick snapshots
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sunny Kumar
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1464150 1467903 1506098
TreeView+ depends on / blocked
 
Reported: 2017-08-16 09:47 UTC by Sunny Kumar
Modified: 2017-12-08 17:38 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1506098 (view as bug list)
Environment:
Last Closed: 2017-12-08 17:38:25 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sunny Kumar 2017-08-16 09:47:21 UTC
Description of problem:

By default, GlusterFS does mount even deactivated snapshot(s) under /run/gluster/snaps. Since we do have a mount, there is a possibility that some process may access the mount, causing issues when trying to umount the volume for instance when deleting the snapshot.


How reproducible:
100%

Steps to Reproduce:
1. Create a snapshot
2. Check for mount point
3. Deactivate a snapshot
4. Check for mount point

Actual results:

1. Newly created snapshot volume is getting listed in mount point.
2. After deactivation of snapshot volume is still present in mount point.

Expected results:

1. Newly created snapshot volume should not be listed in mount point, It should list only after activating the snapshot volume.
2. After deactivation of snapshot volume, mount point should not be present.

Comment 1 Worker Ant 2017-08-16 09:52:02 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: unmounting bricks during snap deactivation) posted (#1) for review on master by Sunny Kumar

Comment 2 Sunny Kumar 2017-08-16 09:59:44 UTC
Detailed discussion on this issue :-

https://github.com/gluster/glusterfs/issues/276

Comment 3 Atin Mukherjee 2017-08-16 10:43:56 UTC
Since we already have a github issue in place, having a bug is an overkill to me.

Comment 4 Worker Ant 2017-08-16 11:16:54 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: unmounting bricks during snap deactivation) posted (#2) for review on master by Sunny Kumar

Comment 5 Worker Ant 2017-08-16 11:28:41 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: unmount bricks during snap deactivation) posted (#3) for review on master by Sunny Kumar

Comment 6 Worker Ant 2017-08-24 10:48:08 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: snpashots issues with other processes           accessing the mounted brick snapshots) posted (#4) for review on master by Sunny Kumar

Comment 7 Worker Ant 2017-08-24 11:11:50 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: snpashot issues with other processes access the mounted brick) posted (#5) for review on master by Sunny Kumar

Comment 8 Worker Ant 2017-08-24 11:15:00 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#6) for review on master by Sunny Kumar

Comment 9 Worker Ant 2017-08-24 20:42:21 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#7) for review on master by Sunny Kumar

Comment 10 Worker Ant 2017-08-28 07:04:06 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#8) for review on master by Sunny Kumar

Comment 11 Worker Ant 2017-09-06 13:02:30 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#9) for review on master by Sunny Kumar

Comment 12 Worker Ant 2017-09-06 15:34:10 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#10) for review on master by Sunny Kumar

Comment 13 Worker Ant 2017-09-12 07:00:14 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#11) for review on master by Sunny Kumar

Comment 14 Worker Ant 2017-09-20 11:44:38 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#12) for review on master by Sunny Kumar

Comment 15 Worker Ant 2017-09-21 06:42:32 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#13) for review on master by Sunny Kumar

Comment 16 Worker Ant 2017-09-29 06:19:29 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#14) for review on master by Sunny Kumar

Comment 17 Worker Ant 2017-09-29 06:27:21 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#15) for review on master by Sunny Kumar

Comment 18 Worker Ant 2017-09-29 06:46:07 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#16) for review on master by Sunny Kumar

Comment 19 Worker Ant 2017-09-29 07:00:48 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issues with other processes accessing the mounted brick) posted (#17) for review on master by Sunny Kumar

Comment 20 Worker Ant 2017-10-04 06:49:09 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issue with other processes accessing the mounted brick) posted (#18) for review on master by Sunny Kumar

Comment 21 Worker Ant 2017-10-10 18:38:17 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issue with other processes accessing the mounted brick) posted (#19) for review on master by Sunny Kumar

Comment 22 Worker Ant 2017-10-12 10:57:35 UTC
REVIEW: https://review.gluster.org/18510 (snapshot: Issue with other processes accessing the mounted brick) posted (#1) for review on master by Sunny Kumar

Comment 23 Worker Ant 2017-10-17 06:44:54 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issue with other processes accessing the mounted brick) posted (#20) for review on master by Sunny Kumar

Comment 24 Worker Ant 2017-10-18 12:55:12 UTC
REVIEW: https://review.gluster.org/18047 (snapshot: Issue with other processes accessing the mounted brick) posted (#21) for review on master by Sunny Kumar

Comment 25 Worker Ant 2017-10-23 10:05:06 UTC
COMMIT: https://review.gluster.org/18047 committed in master by Amar Tumballi (amarts) 
------
commit 2b3b3edee2d849b4aee314048987dc995d9679a1
Author: Sunny Kumar <sunkumar>
Date:   Wed Aug 16 14:04:45 2017 +0530

    snapshot: Issue with other processes accessing the mounted brick
    
    Added code for unmount of activated snapshot brick during snapshot
    deactivation process which make sense as mount point for deactivated
    bricks should not exist.
    
    Removed code for mounting newly created snapshot, as newly created
    snapshots should not mount until it is activated.
    
    Added code for mount point creation and snapshot mount during snapshot
    activation.
    
    Added validation during glusterd init for mounting only those snapshot
    whose status is either STARTED or RESTORED.
    
    During snapshot restore, mount point for stopped snap should exist as
    it is required to set extended attribute.
    
    During handshake, after getting updates from friend mount point for
    activated snapshot should exist and should not for deactivated
    snapshot.
    
    While getting snap status we should show relevent information for
    deactivated snapshots, after this pathch 'gluster snap status' command
    will show output like-
    
    Snap Name : snap1
    Snap UUID : snap-uuid
    
    	Brick Path        :   server1:/run/gluster/snaps/snap-vol-name/brick
    	Volume Group      :   N/A (Deactivated Snapshot)
    	Brick Running     :   No
    	Brick PID         :   N/A
    	Data Percentage   :   N/A
    	LV Size           :   N/A
    
    Fixes: #276
    
    Change-Id: I65783488e35fac43632615ce1b8ff7b8e84834dc
    BUG: 1482023
    Signed-off-by: Sunny Kumar <sunkumar>

Comment 26 Shyamsundar 2017-12-08 17:38:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.