Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1482034

Summary: While updating the network vNIC profile to be with clean traffic ,and running the VM, IP parameters are not passed to the domxml
Product: [oVirt] vdsm Reporter: Ori Ben Sasson <obensass>
Component: GeneralAssignee: Milan Zamazal <mzamazal>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: high Docs Contact:
Priority: unspecified    
Version: ---CC: bugs, michal.skrivanek, mzamazal
Target Milestone: ovirt-4.2.0Keywords: Automation, Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:22:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Ori Ben Sasson 2017-08-16 10:11:03 UTC
Description of problem:
While updating the network vNIC profile to be with clean traffic ,and running the VM, IP parameter doesn't configure on the bridge

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170815155420.gitaed789a.el7.centos.noarch
vdsm-4.20.2-33.gite85019b.el7.centos.x86_64


How reproducible:
100

Steps to Reproduce:
1. Update/Add network vNIC profile to be with clean-traffic
2. run VM
3. update/Add VM NIC with clean traffic filter parameters via REST 

Actual results:
IP parameter doesn't configure on the bridge

Expected results:
IP should be configured on libvirt interface

Additional info:
get xml from the vm: virsh -r dumpxml <vm_name>
<interface type='bridge'>
	<mac address='00:1a:4a:16:20:16'/>
	<source bridge='ovirtmgmt'/>
	<target dev='vnet1'/>
	<model type='virtio'/>
	<filterref filter='clean-traffic'/>
	<alias name='net1'/>
	<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>

Comment 1 Ori Ben Sasson 2017-08-16 10:11:44 UTC
Created attachment 1314050 [details]
logs

Comment 2 Ori Ben Sasson 2017-08-16 10:22:10 UTC
GET request content is: 
url:/ovirt-engine/api/vms/<vm_id>1/nics/<nic_id>/networkfilterparameters 
<network_filter_parameters>
    <network_filter_parameter href="/ovirt-engine/api/vms/<vm_id>/nics/<nic_id>/networkfilterparameters/84651c52-7d55-41dc-990e-a72b5b0cc098" id="84651c52-7d55-41dc-990e-a72b5b0cc098">
        <name>IP</name>
        <value>10.35.128.172</value>
        <nic href="/ovirt-engine/api/vms/<vm_id>/nics/9ca8cafa-f812-46e1-9298-2e46fed33f46" id="9ca8cafa-f812-46e1-9298-2e46fed33f46"/>
    </network_filter_parameter>
</network_filter_parameters>

Comment 3 Michal Skrivanek 2017-08-17 05:02:14 UTC
*** Bug 1482030 has been marked as a duplicate of this bug. ***

Comment 4 Dan Kenigsberg 2017-08-17 05:06:29 UTC
I suspect this, too, is caused by Engine-domxml work.

Comment 5 Michal Skrivanek 2017-08-17 07:12:59 UTC
the filterParameters doesn't seem to be initialized properly in vdsm

Comment 6 Milan Zamazal 2017-08-17 10:00:46 UTC
Yes, it's lost in Vdsm.  I'll post a fix soon.

Comment 7 Red Hat Bugzilla Rules Engine 2017-08-17 10:13:06 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 8 Ori Ben Sasson 2017-08-21 08:23:26 UTC
Verified on ovirt-engine-4.2.0-0.0.master.20170820180837.git59243e9.el7.centos.noarch

Comment 9 Sandro Bonazzola 2017-12-20 11:22:04 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.