Bug 1482076 - [Memory hot unplug] The Defined memory is not updated after hot unplug memory
Summary: [Memory hot unplug] The Defined memory is not updated after hot unplug memory
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.2.0
: ---
Assignee: jniederm
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks: 1228543
TreeView+ depends on / blocked
 
Reported: 2017-08-16 12:11 UTC by Israel Pinto
Modified: 2017-12-20 11:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:02:26 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+
rule-engine: planning_ack+
rule-engine: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)
General Tab (102.12 KB, image/png)
2017-08-16 12:11 UTC, Israel Pinto
no flags Details
engine_log (101.71 KB, application/x-xz)
2017-08-16 12:13 UTC, Israel Pinto
no flags Details
engine.log (101.71 KB, application/x-xz)
2017-08-16 12:14 UTC, Israel Pinto
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 81048 0 master MERGED core: Memory devices spec param size in MiB 2021-02-19 18:46:04 UTC

Description Israel Pinto 2017-08-16 12:11:21 UTC
Created attachment 1314085 [details]
General Tab

Description of problem:
The Defined memory in general tab (in the UI) is not updated 
after hot unplug memory. 

Version-Release number of selected component (if applicable):
Software version:4.2.0-0.0.master.20170813134654.gitaee967b.el7.centos

How reproducible:
All the time

Steps to Reproduce:
1. Create VM with OS
2. Start VM
3. Hotplug memory to VM several time
4. Hot unplug memory 
5. Check guest and General Tab
 

Actual results:
1. The Memory on the guest is updated after each hot unplug
2. THe Defined memory is not updated only the 
"Guest OS Memory Free/Cached/Buffered" felid.

Additional info:
See screenshot of general tab

Comment 1 Israel Pinto 2017-08-16 12:13:15 UTC
Created attachment 1314090 [details]
engine_log

Comment 2 Israel Pinto 2017-08-16 12:14:02 UTC
Created attachment 1314094 [details]
engine.log

Comment 3 Israel Pinto 2017-08-16 12:15:56 UTC
Vm name: test_memory_hotplug
ID: b9cad82e-2708-4b14-9392-7ea66959d38f
Case: https://polarion.engineering.redhat.com/polarion/redirect/project/RHEVM3/workitem?id=RHEVM-22160

Comment 4 Israel Pinto 2017-08-17 10:54:55 UTC
Raising severity,
After stopping and start VM again (all actions: cold restart, PowerOff Run)
The VM memory is not update also. 
I removed all the plugged memory the VM start with the defined memory. 
The is not update also on the guest. 
Unplug is not working after reboot.

Comment 5 jniederm 2017-08-25 12:59:37 UTC
Memory size were not updated since condition [1] was not met since the hot-unplugged memory device seemed to be far larger than it actually were since unit mismatch in 'size' spec param of memory vm device (bug 1482042).

[1]: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnplugMemoryCommand.java;h=a35f6af01179162e762c3e491be099797f7d1872;hb=4a3308f340e057f48bbc5dc140a5f6e19c35063f#l125

Comment 6 Israel Pinto 2017-09-24 14:13:58 UTC
Verify with:
Software version:4.2.0-0.0.master.20170917124606.gita804ef7.el7.centos

Steps:
1. Create VM with OS
2. Start VM
3. Hotplug memory to VM several time
4. Hot unplug memory 
5. Check guest and General Tab

Results:
PASS

Comment 7 Sandro Bonazzola 2017-12-20 11:02:26 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.