Bug 1482205 - Review Request: syncthing-gtk - Syncthing GTK+ GUI
Summary: Review Request: syncthing-gtk - Syncthing GTK+ GUI
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-16 17:50 UTC by Fabio Valentini
Modified: 2017-08-31 14:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-28 22:21:55 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2017-08-16 17:50:06 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-gtk.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-gtk-0.9.2.5-1.fc26.src.rpm

Description: This package contains the GTK+ GUI for syncthing.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21265966


Packager's comments:
--------------------

I've marked the dependency on syncthing as "weak" ("Recommends: syncthing"), since technically, the GUI doesn't need this package for its operation, and the syncthing package isn't available on all of fedora's architectures (only on %{go_arches}). Additionally, this way this python package can stay noarch as it should be.

I've also included a downstream appdata file for this GUI application, since this seems to be needed, and upstream doesn't provide one.

Comment 1 Neal Gompa 2017-08-17 13:58:37 UTC
Taking this review.

Comment 2 Neal Gompa 2017-08-18 03:35:50 UTC
Review notes:

* Package is named appropriately, per packaging guidelines
* Package follows Fedora packaging guidelines
* Package follows Fedora Python packaging guidelines
* Package has no rpmlint issues
* Package builds and installs correctly
* No issues from fedora-review

Looks good to me.

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2017-08-18 11:10:14 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/syncthing-gtk

Comment 4 Fedora Update System 2017-08-19 09:29:14 UTC
syncthing-gtk-0.9.2.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f28ffc58a2

Comment 5 Fedora Update System 2017-08-21 01:22:07 UTC
syncthing-gtk-0.9.2.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7760f8e52

Comment 6 Fedora Update System 2017-08-22 18:07:11 UTC
syncthing-gtk-0.9.2.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f28ffc58a2

Comment 7 Fedora Update System 2017-08-28 22:21:55 UTC
syncthing-gtk-0.9.2.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-08-31 14:54:51 UTC
syncthing-gtk-0.9.2.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.