Spec URL: https://smani.fedorapeople.org/review/perl-Regexp-Pattern.spec SRPM URL: https://smani.fedorapeople.org/review/perl-Regexp-Pattern-0.1.4-1.fc27.src.rpm Description: Collection of regexp patterns Fedora Account System Username: smani
Taken
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ---> Please remove unneeded BR: make - Please wrap %description into lines not longer than 80 chars. - License tag should be 'GPL+ or Artistic'. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Perl". 14 files have unknown license. Detailed output of licensecheck in /home/besser82/vm_shared/fedora/review/1482893-perl-Regexp- Pattern/licensecheck.txt ---> License tag should be 'GPL+ or Artistic'. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Regexp(licensecheck), /usr/share/perl5/vendor_perl/Regexp/Pattern(licensecheck) ---> This is okay. Those dirs are not present in the new version of licensecheck. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [!]: Package complies to the Packaging Guidelines ---> Issues are present. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> Package is noarch'ed and Perl works fine on all arches. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Regexp-Pattern-0.1.4-1.fc27.noarch.rpm perl-Regexp-Pattern-0.1.4-1.fc27.src.rpm perl-Regexp-Pattern.noarch: E: description-line-too-long C Regexp::Pattern is a convention for organizing reusable regexp patterns in modules. perl-Regexp-Pattern.noarch: W: invalid-license Perl perl-Regexp-Pattern.src: E: description-line-too-long C Regexp::Pattern is a convention for organizing reusable regexp patterns in modules. perl-Regexp-Pattern.src: W: invalid-license Perl 2 packages and 0 specfiles checked; 2 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory perl-Regexp-Pattern.noarch: E: description-line-too-long C Regexp::Pattern is a convention for organizing reusable regexp patterns in modules. perl-Regexp-Pattern.noarch: W: invalid-license Perl 1 packages and 0 specfiles checked; 1 errors, 1 warnings. ---> Please wrap %description into lines not longer than 80 chars. Requires -------- perl-Regexp-Pattern (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.26.0) perl(Exporter) perl(strict) Provides -------- perl-Regexp-Pattern: perl(Regexp::Pattern) perl(Regexp::Pattern::Example) perl-Regexp-Pattern Source checksums ---------------- http://search.cpan.org/CPAN/authors/id/P/PE/PERLANCAR/Regexp-Pattern-0.1.4.tar.gz : CHECKSUM(SHA256) this package : e620a542d529981e78863797415b7daf8e2f91f14d92369e15d487d69ba19767 CHECKSUM(SHA256) upstream package : e620a542d529981e78863797415b7daf8e2f91f14d92369e15d487d69ba19767 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1482893 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ===== Solution ===== Package approved! Please fix the named issues during import!
The package should build-require perl-interpreter. Not perl (this is a metapackage with a lot of dependencies). It should buildrequire coreutils because of rm command in the %install section. Actually the whole command could be avoided if NO_PACKLIST=1 argument were passed to "perl Makefile.PL" argument and build-dependency on perl(ExtUtils::MakeMaker) constrained with ">= 6.76" version (this is the first version supporting the NO_PACKLIST argument) added. It's missing BuildRequires on "perl(Exporter)" (lib/Regexp/Pattern.pm:9).
Thanks for the review and the comments, I'll fix the remaining issues @Björn Fedora review is out of date, all build dependencies should be explicitly listed.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Regexp-Pattern