Upstream, this software supports Python 3. Please provide a Python 3 package for Fedora. According to the Python packaging guidelines [0], software must be packaged for Python 3 if upstream supports it. The guidelines give detailed information on how to do this, and even provide an example spec file [1]. The current best practice is to provide subpackages for the two Python versions (called "Common SRPM" in the guidelines). Alternatively, if nothing depends on your Python2 package, you can just switch to Python 3 entirely. It's OK to do this in Rawhide only, however, it would be greatly appreciated if you could push it to Fedora 25 as well. If you need more instructions, a guide for porting Python-based RPMs is available at [2]. If anything is unclear, or if you need any kind of assistance with the porting, you can ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy to help! [0] https://fedoraproject.org/wiki/Packaging:Python [1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file [2] http://python-rpm-porting.readthedocs.io/
Created attachment 1318237 [details] New version including Python 3 subpackage
Hello Andy, may I ask to review the patch, and if it is fine, to make the new package in Fedora? Thank you. Jan
Hello Andy, please, may I ask for your feedback?
> -%filter_provides_in %{python_sitearch}/.*\.so$\ > +%filter_provides_in %{python2_sitearch}/.*\.so$\ > +%filter_provides_in %{python3_sitearch}/.*\.so$\ I think this can be entirely removed because it si not needed any more and those files are never provided so there is no need to filter them out. Even if it was needed, this way it doesn't work. This macro can be used only once (with a regex OR). > +mv %{buildroot}%{python3_sitearch}/simpleparse/stt/TextTools/mxTextTools/mxTextTools.*.so %{buildroot}%{python3_sitearch}/simpleparse/stt/TextTools/mxTextTools/mxTextTools.so Why is this done? It makes zero sense to me. If it is needed, please add a comment explaining why. If not, please don't do it. > +%{python2_sitearch} and > +%{python3_sitearch} I know you are not changing anything here, because this was already done wrong in the original, but this is wrong. A python module package cannot own this directory, it is owned by pythonX-libs. Please at least use %{pythonX_sitearch}/* if nothing more specific.
Hi Miro, thanks for your review. I have provided the updated patch here: https://src.fedoraproject.org/rpms/python-simpleparse/pull-request/1
Miro, thank you for the additional explanation at https://src.fedoraproject.org/rpms/python-simpleparse/pull-request/1. I have updated the patch: https://src.fedoraproject.org/rpms/python-simpleparse/pull-request/2
Hi Andy, may I ask you to review the Pagure PR [1] and rebuild the package? Thank you. [1] https://src.fedoraproject.org/rpms/python-simpleparse/pull-request/2
package handed off to python-sig, feel free to take this BZ too.
I will finish this soon. If not, bump me.
Thanks Jan for the PR. Merged and built.