+++ This bug was initially created as a clone of Bug #1395498 +++ Description of problem: Basically our glusterd service would not start on Ubuntu 14.04. Logs kept saying some old; http://paste.ubuntu.com/23483365 Management volume was same as 7 other machines that were online in our network. Version-Release number of selected component (if applicable): gluster 3.8.5 How reproducible: Okay so the issue we found that in this servers /var/lib/glusterd/peers file for another server, there was a blank space line. Whilst this existed, it would not start the service. We have no idea where this came from suddenly, service had been working since the upgrade to 3.8.5 5 days ago. Expected results: If there is a commented line in these files or a blank space, it not to fail starting the service. Additional info: @JoeJulian advised to lodge a bug after I managed to fix it --- Additional comment from Ryan Mills on 2016-11-15 22:26:36 EST --- Basically when I did a cat /var/lib/glusterd/peers/* It looked like this http://paste.ubuntu.com/23483689/ --- Additional comment from Ryan Mills on 2016-11-15 22:27:01 EST --- I changed it to look like; uuid=01639c5d-0506-4083-b9d3-1176f2dcb912 state=3 hostname1=cb-per-04 hostname2=192.168.0.204 uuid=02c307e9-e57a-4d53-83ee-a5c768e30d6e state=3 hostname1=cb-per-05 uuid=0dff3901-c0a4-493b-b591-a736d50bc8d3 state=3 hostname1=cb-per-07 uuid=11862aef-dbf8-423a-8056-12302aa7dfb6 state=3 hostname1=cb-per-09 uuid=12578c81-3172-4719-b86b-122f82f6be8e state=3 hostname1=cb-per-06 uuid=62522617-7a2a-4a9f-80cc-5906272079b5 state=3 hostname1=cb-per-02 uuid=c06cdd58-ea98-46c2-aab6-b82bcbeab46a state=3 hostname1=cb-per-03 uuid=fbf0facc-2005-48a3-8291-3f834bab3d80 state=3 hostname1=cb-per-08 --- Additional comment from Gaurav Yadav on 2017-08-17 10:33:38 EDT --- Issue is not getting reproduced after multiple trials with latest code base, hence closing the issue. --- Additional comment from Atin Mukherjee on 2017-08-18 01:26:35 EDT --- This bug exists in all the branches, reopening it.
REVIEW: https://review.gluster.org/18066 (glusterd: glusterd fails to start if peers file has blank line) posted (#1) for review on master by Gaurav Yadav (gyadav)
REVIEW: https://review.gluster.org/18066 (glusterd: glusterd fails to start if peers file has blank line) posted (#2) for review on master by Gaurav Yadav (gyadav)
REVIEW: https://review.gluster.org/18066 (glusterd: glusterd fails to start if peers file has blank line) posted (#3) for review on master by Gaurav Yadav (gyadav)
REVIEW: https://review.gluster.org/18066 (glusterd: glusterd fails to start if peers file has blank line) posted (#4) for review on master by Gaurav Yadav (gyadav)
COMMIT: https://review.gluster.org/18066 committed in master by Niels de Vos (ndevos) ------ commit 470fcc266215b48ddea65e9e641c4a750d6358db Author: Gaurav Yadav <gyadav> Date: Fri Aug 18 19:46:47 2017 +0530 glusterd: glusterd fails to start if peers file has blank line Problem: On start of glusterd service, glusterd fetch data from store, while parsing data from store if peers file consists of blank line glusterd fails to start. Fix: With this fix while parsing peers file glusterd will skip blank lines if it contains any. Signed-off-by: Gaurav Yadav <gyadav> Change-Id: I53cd65a54de5f57baef292b2118b70ffb7f99388 BUG: 1482906 Reviewed-on: https://review.gluster.org/18066 Tested-by: Gaurav Yadav <gyadav> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Niels de Vos <ndevos>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report. glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html [2] https://www.gluster.org/pipermail/gluster-users/