Bug 1483350 - libesmtp built w/o SSL support -- compat-openssl10 required
Summary: libesmtp built w/o SSL support -- compat-openssl10 required
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: libesmtp
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pawel Salek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-20 20:21 UTC by Tony Nelson
Modified: 2019-11-27 19:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 19:23:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed fix (351 bytes, patch)
2017-08-21 16:42 UTC, Jaroslav Škarvada
no flags Details | Diff
Spec fix (854 bytes, patch)
2017-08-21 16:44 UTC, Jaroslav Škarvada
no flags Details | Diff
hacks F28 libesmtp-1.0.6-14.fc28.x86_64 to use compat-openssl10 (867 bytes, patch)
2018-07-28 17:05 UTC, Tony Nelson
no flags Details | Diff

Description Tony Nelson 2017-08-20 20:21:43 UTC
Description of problem:
No SSL support in f26 libesmtp, because the OpenSSL interface changed in version 1.1.  Changing the .spec file to use compat-openssl10 fixes this.

I don't do much w/ .spec files, so I'm not providing my obvious changes as a patch.

(I still can't send mail, as I'm having troulble w/ using my self-signed Cert, but that may become another bug report.)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Tony Nelson 2017-08-21 15:43:10 UTC
Just to note that with this change, and balsa also set to use compat-openssl10 (didn't try mixing them) and to accept a self-signed cert (my Bug 1483649 - balsa no longer accepts mail server self-signed certificate), I can send email again and the server logs show proper TLS.

Comment 2 Jaroslav Škarvada 2017-08-21 16:42:56 UTC
Created attachment 1316400 [details]
Proposed fix

Going with openssl 1.0 is dirty solution, better is to fix it the right way. It seems it just need tuning of the openssl autodetection, patch attached. I haven't done any functionality testing yet, could anybody test the scratch build bellow?

https://koji.fedoraproject.org/koji/taskinfo?taskID=21379585

Comment 3 Jaroslav Škarvada 2017-08-21 16:44:49 UTC
Created attachment 1316409 [details]
Spec fix

And spec file fix, we have to use autoconf, oterwise it will go very dirty way :)

Comment 4 Tony Nelson 2017-08-21 16:48:09 UTC
Perhaps you should try it, or at least talk to someone on the devel list who has done such a thing.  There are many changes between the two versions of openssl.

Comment 5 Jaroslav Škarvada 2017-08-21 17:59:12 UTC
(In reply to Tony Nelson from comment #4)
> Perhaps you should try it, or at least talk to someone on the devel list who
> has done such a thing.  There are many changes between the two versions of
> openssl.

I am maintainer of sendmail and postfix and we switched the former successfully to openssl-1.1 some time ago. Trust me, going with compat-openssl10 is really not right thing to do. If there are issues when building with 1.1, please name them.

Comment 6 Jaroslav Škarvada 2017-08-21 18:15:01 UTC
Well, I am short of time (that's why I requested whether anybody could test it and report any issues), but I tested the scratch build from comment 2 for you. Used the test code from [1], reproducer:

$ gcc -o mail-file mail.file.c -lesmtp
$ echo hello > mail.txt
$ ./mail-file -T -s test -h smtp file.txt jskarvad
SMTP_EV_INVALID_PEER_CERTIFICATE: 19: X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN
SMTP_EV_WRONG_PEER_CERTIFICATE - accepted.
SMTP_EV_STARTTLS_OK - TLS started here.
250 Ok: queued as 7610D6A54E
jskarvad: 250 Ok

Aaand the mail came OK. So, are there any objective issues with the scratch build?

[1] https://raw.githubusercontent.com/jbouse-debian/libesmtp/master/examples/mail-file.c

Comment 7 Jaroslav Škarvada 2017-08-22 12:36:30 UTC
Pawel are you OK with patches from comment 2 and comment 3? If yes, I will introduce them into RHEL (where I am maintainer of the libesmtp). Also I could help you in Fedora as a co-maintainer and handle this bug for you.

Comment 8 Fedora End Of Life 2018-05-03 08:12:27 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 9 Fedora End Of Life 2018-05-29 11:36:23 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 10 Jaroslav Škarvada 2018-05-30 08:39:24 UTC
Moving to rawhide.

Comment 11 Jaroslav Škarvada 2018-05-30 08:40:21 UTC
Setting needinfo.

Comment 12 Pawel Salek 2018-07-17 20:58:32 UTC
Is this patch really needed? I Seem to be able build libesmtp for rawhide just fine:

https://koji.fedoraproject.org/koji/taskinfo?taskID=28376663

Comment 13 Jaroslav Škarvada 2018-07-18 14:24:35 UTC
(In reply to Pawel Salek from comment #12)
> Is this patch really needed? I Seem to be able build libesmtp for rawhide
> just fine:
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=28376663

Yes, it's still needed because you are now compiling libesmtp without openssl support, see build log, e.g.: https://kojipkgs.fedoraproject.org//work/tasks/6676/28376676/build.log:
...
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking for SSL_library_init in -lssl... no
...
--with-openssl: no

and final requires:
/sbin/ldconfig
/sbin/ldconfig
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.16)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libdl.so.2()(64bit)
libdl.so.2(GLIBC_2.2.5)(64bit)
libpthread.so.0()(64bit)
libpthread.so.0(GLIBC_2.2.5)(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

there is no openssl support built-in.

Comment 14 Pawel Salek 2018-07-21 04:44:19 UTC
I stand corrected - thank you!

I have just pushed the update.

Comment 15 Tony Nelson 2018-07-28 17:05:00 UTC
Created attachment 1471263 [details]
hacks F28 libesmtp-1.0.6-14.fc28.x86_64 to use compat-openssl10

F28 balsa can't send email because libesmtp is built without openssl support.  Perhaps the rawhide version fixes this, I don't know, but that hasn't gotten to F28.  This patch to the spec file builds against compat-openssl10 and permits balsa to send mail.

(balsa itself has other issues -- I don't think anyone but me is using it in Fedora.)

Comment 16 Jaroslav Škarvada 2018-07-30 10:07:12 UTC
(In reply to Tony Nelson from comment #15)
> Created attachment 1471263 [details]
> hacks F28 libesmtp-1.0.6-14.fc28.x86_64 to use compat-openssl10
> 
> F28 balsa can't send email because libesmtp is built without openssl
> support.  Perhaps the rawhide version fixes this, I don't know, but that
> hasn't gotten to F28.  This patch to the spec file builds against
> compat-openssl10 and permits balsa to send mail.
> 
> (balsa itself has other issues -- I don't think anyone but me is using it in
> Fedora.)

Just merging the f29 version should work. If not, we should fix the core problem (if there is any).

Comment 17 Jan Kurik 2018-08-14 11:20:46 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 18 Ben Cotton 2019-10-31 20:44:14 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 19 Ben Cotton 2019-11-27 19:23:39 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.