Description of problem: Balsa can either send a message immediately or queue it for later send, depending on Preferences v Mail Options - Outgoing v "Send button always queues outgoing mail in outbox". The Message window toolbar button correctly reflects this state. Previously (balsa-2.5.1 and before) pressing that button would queue the message, but in balsa-2.5.3 it sends the message immediately. File menu Queue does queue the message. Version-Release number of selected component (if applicable): How reproducible: Each of a few times with several emails. Note that I'm one of the people who can't send email from balsa, so I'm not doing it much yet. Steps to Reproduce: 1. Ensure balsa is set to queue outgoing messages 2. Open a draft message. 3. Press Queue toolbar button. Actual results: Message is sent immediately (or in my case, attempted and fails). Expected results: Message is placed in Outbox. Additional info:
Possibly because both the menu item and toolbar item are called "send", clicking on the toolbar item calls sw_send_activated() instead of sw_toolbar_send_activated() as it should. See src/sendmsg-window.c. Perhaps they should have distinct names.
Created attachment 1316354 [details] Fixes that the Send Message toolbar Queue button sends instead
Thanks for the report, and for the patch! Looks like sw_toolbar_send_activated was implemented but never used :-( I've pushed your patch to the git master branch, so it will be reflected in any new release of Balsa. It may not be a bug-fix patch to 2.5.3, because master has many other changes, including dropping dependence on libesmtp.
This message is a reminder that Fedora 26 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '26'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 26 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
There have been a couple of releases with the fix, so this bug can be closed as "fixed".
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
The problem appears again in F28 balsa and the fix is not in the SRPM -- I had to build again with my patch. Is it not a new enough release?
This message is a reminder that Fedora 27 is nearing its end of life. On 2018-Nov-30 Fedora will stop maintaining and issuing updates for Fedora 27. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '27'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 27 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.