Bug 1483355 - balsa crashes in atoi() in lbs_process_queue when send
Summary: balsa crashes in atoi() in lbs_process_queue when send
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: balsa
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pawel Salek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-20 21:17 UTC by Tony Nelson
Modified: 2018-05-29 11:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-05-29 11:36:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tony Nelson 2017-08-20 21:17:01 UTC
Description of problem:
balsa crashes when sending mail.  The message was created in balsa-2.5.1, balsa was upgraded to 2.5.3, and an attempt was made to send the message.  balsa crashes in atoi() called from lbs_process_queue:

711	        msg->request_dsn =
712	        	(atoi(libbalsa_message_get_user_header(msg, "X-Balsa-DSN")) != 0);

This is because the requested header does not exist (it was added to balsa somewhere between 2.5.1 and 2.5.3).  Not checking is a bug in balsa, even if it saves a couple of lines of code, as it is reasonable that some users would upgrade with queued mail, or find some other way to break this fragile code.

Version-Release number of selected component (if applicable):


How reproducible:
always with an old queued message across an upgrade of balsa.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Peter Bloomfield 2017-08-20 22:46:50 UTC
Thanks for the report! This is one bug that we can fix in the git source tree. A patch has been pushed to master.

Comment 2 Fedora End Of Life 2018-05-03 08:12:13 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Peter Bloomfield 2018-05-03 12:36:10 UTC
The current Balsa release contains the fix, so this bug can be closed as "fixed".

Comment 4 Fedora End Of Life 2018-05-29 11:36:10 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.