Bug 1483467 - Container Review Request: passenger - Phusion Passenger web server and application server
Summary: Container Review Request: passenger - Phusion Passenger web server and applic...
Keywords:
Status: NEW
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-21 08:13 UTC by Honza Horak
Modified: 2019-01-01 02:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
mskalick: fedora-review+


Attachments (Terms of Use)

Description Honza Horak 2017-08-21 08:13:38 UTC
Dockerfile URL: https://hhorak.fedorapeople.org/passenger-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/passenger-docker/

Description: Phusion Passenger web server and application server configured with Apache httpd web server. It also provides a Ruby platform for building and running applications. Node.js is preinstalled for assets compilation.

Fedora Account System Username: hhorak

Comment 1 Marek Skalický 2017-11-03 09:37:06 UTC
Things to fix:

1. Tag is missing in FROM [1]
2. Help file is missing:

"must have one of the two following names:

    help.1
    README.md 

It must also be COPYed into the container, to live in the base directory as `/help.1` or `README.md` so that it can be found by other users." [1]



[1] https://fedoraproject.org/wiki/Container:Guidelines#FROM
[2] https://fedoraproject.org/wiki/Container:Guidelines#Help_File

Comment 2 Honza Horak 2017-11-07 08:31:13 UTC
The README.md is there, it's just not listed, not sure why:
https://hhorak.fedorapeople.org/passenger-docker/README.md

It's now also installed in the Dockerfile into /README.md

Comment 3 Marek Skalický 2017-11-07 17:00:09 UTC
Please also fix

1. Tag is missing in FROM [1]

Comment 4 Honza Horak 2017-12-11 09:08:19 UTC
Tag added now.

Comment 5 Marek Skalický 2017-12-13 14:45:27 UTC
Thanks for the fixes.
All is right now.

Comment 6 Gwyn Ciesla 2017-12-16 16:03:53 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/passenger


Note You need to log in before you can comment on or make changes to this bug.