Bug 1484203 - webhook should not trigger duplicate build
Summary: webhook should not trigger duplicate build
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Copr
Classification: Community
Component: backend
Version: unspecified
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Copr Team
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-23 02:41 UTC by Marc Dequènes (Duck)
Modified: 2020-12-11 13:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-11 12:01:52 UTC


Attachments (Terms of Use)

Description Marc Dequènes (Duck) 2017-08-23 02:41:13 UTC
Description of problem:
If I push changes with a tag on the HEAD, then two events are fired, which is ok, but Copr should detect a build of the same commit is already being run and save energy.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. configure webhooks as the doc says
2. commit a change and tag the HEAD
3. push changes and tags

Actual results:
One build is fired for the latest commit, another for the tag.

Expected results:
One build is fired for the latest commit, no build fired for the tag as it correspond to the same commit ID.

Additional info:
Triggering a new build is useful to rebuild an old version, but in this case the build is ongoing and nothing changed between the two events.

Comment 2 Pavel Raiskup 2020-12-11 12:01:52 UTC
We have to separate tag events from push events, and add a special
check box for them, this is tracked upstream:
https://pagure.io/copr/copr/issue/628


Note You need to log in before you can comment on or make changes to this bug.