Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1484304

Summary: The excluder packages shouldn't be updated if healthy check failed
Product: OpenShift Container Platform Reporter: Anping Li <anli>
Component: Cluster Version OperatorAssignee: Jan Chaloupka <jchaloup>
Status: CLOSED ERRATA QA Contact: Anping Li <anli>
Severity: medium Docs Contact:
Priority: low    
Version: 3.7.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 22:07:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Anping Li 2017-08-23 08:38:16 UTC 
Description of problem:

Version-Release number of the following components:
For verify_health_checks.yml [1] was behind disable_master_excluders.yml& disable_node_excluders.yml,  the v3.7 excluder packages [2] will be updated to v3.7 even if disk/memory check fail.


[1] https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade.yml

[2] 
atomic-openshift-excluder-3.7.0-0.104.0.git.0.c420cf9.el7.noarch
atomic-openshift-docker-excluder-3.7.0-0.104.0.git.0.c420cf9.el7.noarc

How reproducible:
always

Steps to Reproduce:
1. RPM install OCP v3.6 and make the disk size is less than 10G
2. upgrade to v3.7
3. check the installed packages

Actual results:
2. the upgrade was abort for healthy check failed
3. the excluder packages was update
[root@host3-ha-1 ~]# rpm -qa|grep openshift
tuned-profiles-atomic-openshift-node-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64
atomic-openshift-excluder-3.7.0-0.104.0.git.0.c420cf9.el7.noarch
atomic-openshift-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64
atomic-openshift-node-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64
atomic-openshift-master-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64
atomic-openshift-docker-excluder-3.7.0-0.104.0.git.0.c420cf9.el7.noarch
atomic-openshift-clients-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64
atomic-openshift-sdn-ovs-3.6.173.0.1-1.git.0.3f0213b.el7.x86_64

Expected results:

Additional info:
No update happed if healty check failed.
Comment 1 Jan Chaloupka 2017-09-14 12:17:13 UTC 
Upstream PR: https://github.com/openshift/openshift-ansible/pull/5413
Comment 2 openshift-github-bot 2017-09-23 13:15:33 UTC 
Commit pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/988d9a27e88f7b14282f9e2d5882fa045e7d879c
Merge pull request #5413 from ingvagabund/disable-excluders-after-pre-checks

Automatic merge from submit-queue

Move some pre-checks before excluders are disabled

Some pre-checks needs an OCP version which is detected by a set of tasks that need the excluders to be disabled. So at the best I can move some pre-checks before the excluders are disabled. However, there will be still some checks that can fail with excluders updated to the newer version.

Bug: 1484304
Comment 3 Anping Li 2017-10-16 07:17:30 UTC 
No v3.7 excluder packages was installed when physical checking failed when use openshift-ansible-3.7.0-0.155.0, so move bug to verified
Comment 6 errata-xmlrpc 2017-11-28 22:07:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188