Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1484629

Summary: Miss new boot entry after upgrade to ovirt-node-ng 4.2
Product: [oVirt] ovirt-node Reporter: jianwu <jiawu>
Component: Installation & UpdateAssignee: Yuval Turgeman <yturgema>
Status: CLOSED CURRENTRELEASE QA Contact: jianwu <jiawu>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.2CC: bugs, cshao, dguo, huzhao, jiawu, niwang, qiyuan, rbarry, sbonazzo, weiwang, yaniwang, ycui, yzhao
Target Milestone: ovirt-4.2.0Keywords: TestBlocker
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
rbarry: devel_ack+
cshao: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: When creating new LVs for NIST, on a non-NIST compatible system, we create and mount the /var* LVs in the wrong order. Consequence: We mount /var/log over /var/log/audit, which causes an error when we try to `umount -R` Fix: When creating the LVs, sort the target mount point, making sure /var/log/audit is under /var/log and /var/log under /var. Result: `umount -R` works, the update process finishes successfully, and the new boot entry is in place.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 10:46:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
upgrade log
none
/tmp/imgbase.log
none
Comment 6: All logs from host(/tmp/imgbased.log, /var/log, sosreport)
none
sosreport, /var/log
none
/tmp/imgbased.log
none
/tmp/imgbase.log none

Description jianwu 2017-08-24 03:42:35 UTC
Created attachment 1317406 [details]
upgrade log

Description of problem:
After upgrade to ovirt-node-ng 4.2 from ovirt-node-ng 4.1 upstream version, missing new layer boot entry.

Version-Release number of selected component (if applicable):
Old version:
ovirt-node-ng-4.1.0-0.20170122.0
New version:
ovirt-node-ng-4.2.0-0.20170822.0

How reproducible:
100

Steps to Reproduce:
1. Clean install ovirt-node-ng-4.1.0-0.20170122.0
2. Download ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch.rpm
3. Upgrade to new build via "yum install *rpm"
4. Reboot the systemCheck its status

Actual results:
After step3, there is failed info during upgrade
After step4, missing new layer boot entry

Expected results:
After step4, there should be new layer boot entry and can log in successfully

Additional info:

Comment 1 jianwu 2017-08-24 05:21:04 UTC
(In reply to jianwu from comment #0)
> Created attachment 1317406 [details]
> upgrade log
> 
> Description of problem:
> After upgrade to ovirt-node-ng 4.2 from ovirt-node-ng 4.1 upstream version,
> missing new layer boot entry.
> 
> Version-Release number of selected component (if applicable):
> Old version:
> ovirt-node-ng-4.1.0-0.20170122.0
> New version:
> ovirt-node-ng-4.2.0-0.20170822.0
> 
> How reproducible:
> 100
> 
> Steps to Reproduce:
> 1. Clean install ovirt-node-ng-4.1.0-0.20170122.0
> 2. Download
> ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.
> centos.noarch.rpm
> 3. Upgrade to new build via "yum install *rpm"
> 4. Reboot the systemCheck its status
> 
> Actual results:
> After step3, there is failed info during upgrade
> After step4, missing new layer boot entry
> 
> Expected results:
> After step4, there should be new layer boot entry and can log in successfully
> 
> Additional info:

Update:
After step 3, when run:
#yum install ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch.rpm
=======================
---------------------------
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch                                                                    1/2
warning: %post(ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch
  Erasing    : ovirt-node-ng-image-update-placeholder-4.1.0-0.8.rc1.el7.centos.noarch                                                                                     2/2
  Verifying  : ovirt-node-ng-image-update-4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos.noarch                                                                    1/2
  Verifying  : ovirt-node-ng-image-update-placeholder-4.1.0-0.8.rc1.el7.centos.noarch                                                                                     2/2

Installed:
  ovirt-node-ng-image-update.noarch 0:4.2.0-0.5.master.20170822000033.gitf718d23.el7.centos                                                                                  

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.1.0-0.8.rc1.el7.centos 
==========================

it shows that upgrade is successuly

Comment 2 Ryan Barry 2017-08-24 13:50:12 UTC
Can you please attach /tmp/imgbased.log as well in the future?

I'll see if I can reproduce this.

Comment 3 Red Hat Bugzilla Rules Engine 2017-08-24 13:50:18 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 4 Ning Wang 2017-08-25 01:07:56 UTC
Created attachment 1317954 [details]
/tmp/imgbase.log

Comment 5 Ning Wang 2017-08-25 01:09:27 UTC
(In reply to Ryan Barry from comment #2)
> Can you please attach /tmp/imgbased.log as well in the future?
> 
> I'll see if I can reproduce this.

Sure, I have updated it (attachment 1317954 [details]), thanks for reminding

Comment 6 Yuval Turgeman 2017-08-30 11:26:06 UTC
Can you please try to reattach the log, the tarball seems to be empty.
Thanks !

Comment 7 Huijuan Zhao 2017-08-31 03:03:24 UTC
Created attachment 1320362 [details]
Comment 6: All logs from host(/tmp/imgbased.log, /var/log, sosreport)

Comment 8 Huijuan Zhao 2017-08-31 03:06:34 UTC
Reattached the log, the testing versions are as below:

# imgbase layout
ovirt-node-ng-4.1.1-0.20170322.0
 +- ovirt-node-ng-4.1.1-0.20170322.0+1
ovirt-node-ng-4.2.0-0.20170822.0
 +- ovirt-node-ng-4.2.0-0.20170822.0+1

Comment 9 Yuval Turgeman 2017-09-06 14:57:55 UTC
I can't reproduce this one, can you please try again with a more recent 4.2 node-ng ?

Comment 10 jianwu 2017-09-15 04:43:10 UTC
(In reply to Yuval Turgeman from comment #9)
> I can't reproduce this one, can you please try again with a more recent 4.2
> node-ng ?

I have tried to test on ovirt-node-ng-4.2.0-0.20170914.0

Test version:
old build:ovirt-node-ng-4.1.2-0.20170523.0
new bulid:ovirt-node-ng-4.2.0-0.20170914.0

Test steps:
1. Clean install ovirt-node-ng-4.1.2-0.20170523.0
2. Download ovirt-node-ng-image-update-4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos.noarch.rpm
3. Upgrade to new build via "yum install *rpm"
4. Reboot the system and check its status

Test results:
1.After step 3, some info as follows:
Running transaction
  Installing : ovirt-node-ng-image-update-4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos.noarch                                                                                                         1/2 
warning: %post(ovirt-node-ng-image-update-4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos.noarch
  Erasing    : ovirt-node-ng-image-update-placeholder-4.1.2-1.el7.centos.noarch                                                                                                                                2/2 
  Verifying  : ovirt-node-ng-image-update-4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos.noarch                                                                                                         1/2 
  Verifying  : ovirt-node-ng-image-update-placeholder-4.1.2-1.el7.centos.noarch                                                                                                                                2/2 

Installed:
  ovirt-node-ng-image-update.noarch 0:4.2.0-0.5.master.20170914000023.gitbc600bf.el7.centos                                                                                                                        

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.1.2-1.el7.centos                                                                                                                                               

Complete!
------------------------------------------------------------------------------
#imgbase layout
ovirt-node-ng-4.1.2-0.20170523.0
 +- ovirt-node-ng-4.1.2-0.20170523.0+1
ovirt-node-ng-4.2.0-0.20170914.0
 +- ovirt-node-ng-4.2.0-0.20170914.0+1

#cat /etc/grub2.cfg
------------------------
### BEGIN /etc/grub.d/10_linux ###
menuentry 'ovirt-node-ng-4.1.2-0.20170523.0' --class centos --class gnu-linux --class gnu --class os --unrestricted $menuentry_id_option 'gnulinux-3.10.0-514.16.1.el7.x86_64-advanced-/dev/mapper/onn-root' {
	load_video
	set gfxpayload=keep
	insmod gzio
	insmod part_msdos
	insmod ext2
	set root='hd0,msdos1'
	if [ x$feature_platform_search_hint = xy ]; then
	  search --no-floppy --fs-uuid --set=root --hint-bios=hd1,msdos1 --hint-efi=hd1,msdos1 --hint-baremetal=ahci1,msdos1 --hint='hd0,msdos1'  3e4fadec-f88c-4eb7-9027-b637318bb48d
	else
	  search --no-floppy --fs-uuid --set=root 3e4fadec-f88c-4eb7-9027-b637318bb48d
	fi
	linux16 /ovirt-node-ng-4.1.2-0.20170523.0+1/vmlinuz-3.10.0-514.16.1.el7.x86_64 root=/dev/onn/ovirt-node-ng-4.1.2-0.20170523.0+1 ro crashkernel=auto rd.lvm.lv=onn/ovirt-node-ng-4.1.2-0.20170523.0+1 rd.lvm.lv=onn/var rd.lvm.lv=onn/swap rhgb quiet LANG=en_US.UTF-8 img.bootid=ovirt-node-ng-4.1.2-0.20170523.0+1
	initrd16 /ovirt-node-ng-4.1.2-0.20170523.0+1/initramfs-3.10.0-514.16.1.el7.x86_64.img
}

### END /etc/grub.d/10_linux ###
--------------------------------------
miss new boot entry on /etc/grub2.cfg.

2.After step 4,
#imgbase w
[INFO] You are on ovirt-node-ng-4.1.2-0.20170523.0+1

So, I think this bug still exits on this build

Comment 11 jianwu 2017-09-15 04:44:59 UTC
Created attachment 1326292 [details]
sosreport, /var/log

Comment 12 jianwu 2017-09-15 04:45:42 UTC
Created attachment 1326293 [details]
/tmp/imgbased.log

Comment 15 jianwu 2017-09-27 07:14:50 UTC
Created attachment 1331318 [details]
/tmp/imgbase.log

Comment 16 jianwu 2017-09-27 07:21:45 UTC
Description of problem:
After upgrade to ovirt-node-ng 4.2 form old upstream version, new boot entry miss and "/etc/grub2.cfg" or "/etc/grub2-efi.cfg"  could not find new boot entry info both on UEFI and BIOS machine

Version-Release number of selected component (if applicable):
Old version:
ovirt-node-ng-4.1.2-0.20170523.0
New version:
ovirt-node-ng-4.1.2-0.20170612.0

How reproducible:
100
keyword: Upgrade
Testblocker
Regression

Steps to reproduce:
1. Clean install ovirt-node-ng-installer-ovirt-4.1-2017052309.iso(ovirt-node-ng-4.1.2-0.20170523.0+1)
2. Download ovirt-node-ng-image-update-4.2.0-0.0.master.20170926014924.gitf5d3c3d.el7.centos.noarch.rpm
3. Upgrade host via "yum install *rpm"
4. Reboot the system
5. Check its status

Actual result:
1. After step 3,
---------------------------------------------------------------------------------------
Installed:
  ovirt-node-ng-image-update.noarch 0:4.2.0-0.0.master.20170926014924.gitf5d3c3d.el7.centos                                                                                  

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.1.2-1.el7.centos 
---------------------------------------------------------------------------------------
2. After step5,
#imgbase layout
ovirt-node-ng-4.1.2-0.20170523.0
 +- ovirt-node-ng-4.1.2-0.20170523.0+1
ovirt-node-ng-4.2.0-0.20170926.0
 +- ovirt-node-ng-4.2.0-0.20170926.0+1
#imgbase w
[INFO] You are on ovirt-node-ng-4.1.2-0.20170523.0+1

Expected Results:
1. After step 5,
#imgbase w
[INFO] You are on ovirt-node-ng-4.2.0-0.20170926.0+1

Additional info:
Clean install ovirt-node-ng-installer-ovirt-4.1-2017040614.iso(ovirt-node-ng-4.1.2-0.20170612.0), upgrade from ovirt-node-ng-4.1.2-0.20170612.0 to ovirt 4.2 latest version, has encountered this issue

This bug is not fixed, and block upgrade test, detail info come to attachment 1331318 [details]

Comment 17 Yuval Turgeman 2017-09-27 07:36:10 UTC
The bug is fixed in the latest version of imgbased (from 20170926), so it will probably take another day for it to be added to a new node image.  What version are you seeing for imgbased ?

Comment 18 jianwu 2017-09-27 07:47:13 UTC
(In reply to Yuval Turgeman from comment #17)
> The bug is fixed in the latest version of imgbased (from 20170926), so it
> will probably take another day for it to be added to a new node image.  What
> version are you seeing for imgbased ?

After upgrade
#rpm -qa |grep imgbase 
imgbased-0.9.27-1.el7.centos.noarch
#imgbase --version
imgbased-0.9.27

According our test results, the bug exits now.
Is it any miss from our parts?

Comment 19 jianwu 2017-09-27 08:02:34 UTC
(In reply to Yuval Turgeman from comment #17)
> The bug is fixed in the latest version of imgbased (from 20170926), so it
> will probably take another day for it to be added to a new node image.  What
> version are you seeing for imgbased ?

Update 
Update:
Version-Release number of selected component (if applicable):
Old version:
ovirt-node-ng-4.1.2-0.20170523.0
New version:
ovirt-node-ng-4.2.0-0.20170926.0

Comment 20 jianwu 2017-09-27 08:47:10 UTC
(In reply to jianwu from comment #16)
> Description of problem:
> After upgrade to ovirt-node-ng 4.2 form old upstream version, new boot entry
> miss and "/etc/grub2.cfg" or "/etc/grub2-efi.cfg"  could not find new boot
> entry info both on UEFI and BIOS machine
> 
> Version-Release number of selected component (if applicable):
> Old version:
> ovirt-node-ng-4.1.2-0.20170523.0
> New version:
> ovirt-node-ng-4.1.2-0.20170612.0

Update:
Version-Release number of selected component (if applicable):
Old version:
ovirt-node-ng-4.1.2-0.20170523.0
New version:
ovirt-node-ng-4.2.0-0.20170926.0

As the Comment 16, Comment 18, should change status to ASSIGNED

Comment 21 Yuval Turgeman 2017-09-27 11:33:09 UTC
This needs to be tested once imgbased (with the relevant patch) gets published

Comment 22 jianwu 2017-09-28 06:02:01 UTC
Strictly test follow as Comment 16


Version-Release number of selected component (if applicable):
Old version:
ovirt-node-ng-4.1.2-0.20170523.0
New version:
ovirt-node-ng-4.2.0-0.20170927.0

Test steps:
as Comment 16


Test results:
After upgrade from ovirt-node-ng-4.1.2-0.20170523.0 to ovirt-node-ng-4.2.0-0.20170927.0 and reboot into new system
#imgbase w
You are on ovirt-node-ng-4.2.0-0.20170927.0+1
#imgbase layout
ovirt-node-ng-4.1.2-0.20170523.0
 +- ovirt-node-ng-4.1.2-0.20170523.0+1
ovirt-node-ng-4.2.0-0.20170927.0
 +- ovirt-node-ng-4.2.0-0.20170927.0+1
#rpm -qi imgbased | grep Build
Build Date  : Wed 27 Sep 2017 07:31:06 PM CST
Build Host  : vm0093.workers-phx.ovirt.org

According to test results, I think this bug is fixed on ovirt-node-ng-4.2 latest version, so I will change status into VERIFIED

Comment 23 Sandro Bonazzola 2017-12-20 10:46:49 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.