Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-bbc-iplayer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-bbc-iplayer-1.1-1.fc26.src.rpm Description: Integration of BBC iPlayer into your linux desktop via Nuvola Player. This is a beta release: support for HTML5 Media Source Extensions (MSE) is new to WebKitGtk and may be still incomplete. Most BBC content works, most of the time, but not all. In those cases you can still use the Flash player, but Nuvola will be unable to detect or control playing state. Fedora Account System Username: martinkg rpmlint -i -v nuvola-app-bbc-iplayer.spec /home/martin/rpmbuild/SRPMS/nuvola-app-bbc-iplayer-1.1-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-bbc-iplayer-1.1-1.fc26.noarch.rpm nuvola-app-bbc-iplayer.spec: I: checking nuvola-app-bbc-iplayer.spec: I: checking-url https://github.com/tiliado/nuvola-app-bbc-iplayer/archive/1.1.tar.gz#/nuvola-app-bbc-iplayer-1.1.tar.gz (timeout 10 seconds) nuvola-app-bbc-iplayer.src: I: checking nuvola-app-bbc-iplayer.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-bbc-iplayer.src: I: checking-url https://github.com/tiliado/nuvola-app-bbc-iplayer (timeout 10 seconds) nuvola-app-bbc-iplayer.src: I: checking-url https://github.com/tiliado/nuvola-app-bbc-iplayer/archive/1.1.tar.gz#/nuvola-app-bbc-iplayer-1.1.tar.gz (timeout 10 seconds) nuvola-app-bbc-iplayer.noarch: I: checking nuvola-app-bbc-iplayer.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-bbc-iplayer.noarch: I: checking-url https://github.com/tiliado/nuvola-app-bbc-iplayer (timeout 10 seconds) nuvola-app-bbc-iplayer.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppBbcIplayer.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
Hello, You need to add a comment breaking down the Licenses: what part s BSD, what part is CC. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* BSD (2 clause)", "BSD (2 clause)", "*No copyright* CC by-sa (v3.0)", "*No copyright* CC by (v3.0)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/nuvola-app-bbc-iplayer /review-nuvola-app-bbc-iplayer/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/nuvolaruntime/web_apps(nuvola-app-mixcloud, nuvola-app- bandcamp, nuvola-app-amazon-cloud-player, nuvolaruntime-devel) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in nuvola-app-bbc-iplayer [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nuvola-app-bbc-iplayer-1.1-1.fc28.noarch.rpm nuvola-app-bbc-iplayer-1.1-1.fc28.src.rpm nuvola-app-bbc-iplayer.noarch: W: spelling-error %description -l en_US linux -> Linux nuvola-app-bbc-iplayer.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppBbcIplayer.desktop nuvola nuvola-app-bbc-iplayer.src: W: spelling-error %description -l en_US linux -> Linux 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Ha I misunderstood, the whole program is dual licensed, so it's okay. Package accepted.
Ha no, I was right: the icons are under CC: src/icon*.svg Copyright 2011 Alexander King alexanderddking Copyright 2011 Arturo Torres Sánchez arturo.ilhuitemoc License: CC-BY-3.0 So you need to add a comment before the License: tag explaining that everything is BSD except the icons.
(In reply to Robert-André Mauchin from comment #3) > Ha no, I was right: the icons are under CC: > > src/icon*.svg > > Copyright 2011 Alexander King alexanderddking > Copyright 2011 Arturo Torres Sánchez arturo.ilhuitemoc > License: CC-BY-3.0 > > So you need to add a comment before the License: tag explaining that > everything is BSD except the icons. done. Thanks for the review.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-bbc-iplayer
package has been built successfully on f25, f26, f27 and rawhide.