Bug 1485450 - add %ghost %{_libdir}/libnssckbi.so
Summary: add %ghost %{_libdir}/libnssckbi.so
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: p11-kit
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1484449
TreeView+ depends on / blocked
 
Reported: 2017-08-25 18:25 UTC by Kai Engert (:kaie) (inactive account)
Modified: 2017-08-28 15:03 UTC (History)
7 users (show)

Fixed In Version: p11-kit-0.23.8-2.fc28
Clone Of:
Environment:
Last Closed: 2017-08-28 15:03:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch v1 (893 bytes, patch)
2017-08-25 18:32 UTC, Kai Engert (:kaie) (inactive account)
dueno: review+
Details | Diff

Description Kai Engert (:kaie) (inactive account) 2017-08-25 18:25:15 UTC
After bug 1484449, we no longer have any package providing %{_libdir}/libnssckbi.so for the automatic dependencies.

Because p11-kit-trust installs that as a symlink, it should use a %ghost file to make it obvious to RPM that it's providing it, thanks to Kamil Dudka for that suggestion.

Because I've already broken Rawhide with my change, and because the fix seems to be obviously correct and simple, I'd like to push that fix immediately, to unbreak everyone who might already be affected by the regression.

I've built the following change locally, and after installing it, it fixed the regression that was reported in bug 1484449.

@@ -123,6 +123,7 @@ fi
 %files trust
 %{_bindir}/trust
 %dir %{_libdir}/pkcs11
+%ghost %{_libdir}/libnssckbi.so
 %{_libdir}/pkcs11/p11-kit-trust.so
 %{_datadir}/p11-kit/modules/p11-kit-trust.module
 %{_libexecdir}/p11-kit/trust-extract-compat

Comment 1 Kai Engert (:kaie) (inactive account) 2017-08-25 18:32:04 UTC
Created attachment 1318274 [details]
patch v1

Daiki, is it OK if I commit/build that into rawhide?

Comment 2 Kai Engert (:kaie) (inactive account) 2017-08-25 18:36:29 UTC
scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21469431

Comment 3 Kai Engert (:kaie) (inactive account) 2017-08-25 18:46:18 UTC
In bug 1484449 comment 3, Anton Guda suggested that p11-kit-trust could potentially install a symlink as part of the package, not as part of a script.

Daiki, do you have any preference here?

Maybe keeping the existing approach is simpler.

(If we decided to switch, we'd have to carefully think about migration, downgrading etc. between packages that still use the script approach.)

Comment 4 Daiki Ueno 2017-08-28 12:20:42 UTC
Comment on attachment 1318274 [details]
patch v1

(In reply to Kai Engert (:kaie) from comment #1)
> Created attachment 1318274 [details]
> patch v1
> 
> Daiki, is it OK if I commit/build that into rawhide?

Sure, thank you.


Note You need to log in before you can comment on or make changes to this bug.