Created attachment 1318721 [details] A patch introducing Qt5 builds and fixing an upstream regression Description of problem: Please build QuiteRSS against Qt5, replace using the patched Qt4's QtWebKit by Qt5-QtWebKit. Version-Release number of selected component (if applicable): quiterss-0.18.8-1.fc26.x86_64 How reproducible: always – packaging Steps to Reproduce: 1. install and run QuiteRSS Actual results: QuiteRSS is using Qt4 and a very old version of QtWebKit. Expected results: QuiteRSS upstream has switched to Qt5 in 0.18.0 [1], which enables HiDPI support, support for Wayland, and other useful stuff. Also, the qtwebkit (Qt4) package has not seen any security patches lately, but qt5-qtwebkit (Qt5) has been actively maintained in the last few months. I'd really like to get security patches to apply to quiterss. Additional info: Upstream introduced a regression in the Qt5 port [2], which they refuse to fix even 2 years after it has been reported. I guess this regression was the reason for not building quiterss with Qt5 in the first place, see also #1242606. The attached patch should be enough to make this transition happen without regressions to the user. I've applied it to quiterss, rebuilt it using `rpmbuild -ba quiterss.spec` and installed it. It correctly finds and uses my old QuiteRSS data dir. [1] https://github.com/QuiteRSS/quiterss/blob/master/CHANGELOG#L54 [2] https://github.com/QuiteRSS/quiterss/issues/792
*bump* Any chance to get this patch added to Fedora's QuiteRSS build?
Sorry, was too busy. Now quiterss is rebuilding for version 0.18.9. We are to deside what to build: * qt4 only version (as now) * qt5 version * qt4 AND qt5 versions (that presumes additional common package (may be)).
(In reply to Christian Stadelmann from comment #1) > *bump* Any chance to get this patch added to Fedora's QuiteRSS build? New version bumped. And seems best way is to build qt5-only version. I'll try it.
(In reply to Eugene A. Pivnev from comment #3) > (In reply to Christian Stadelmann from comment #1) > > *bump* Any chance to get this patch added to Fedora's QuiteRSS build? > > New version bumped. > And seems best way is to build qt5-only version. > I'll try it. Thank you! On qt5-only: +1. Qt4 is pretty much phased out. No need to still use it. The Qt5 version works fine, even in a GNOME/Wayland session.
Created attachment 1386323 [details] Patch for src/application/mainapplication.cpp (not applicable to spec file)
Any update?
Pull request: https://src.fedoraproject.org/rpms/quiterss/pull-request/1
This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.