Spec URL: https://smani.fedorapeople.org/review/svg2svgt.spec SRPM URL: https://smani.fedorapeople.org/review/svg2svgt-0.9.6-0.1.git7a182a9.fc28.src.rpm Description: SVG to SVG Tiny converter Fedora Account System Username: smani
You must provide a desktop file for svg2svgt-gui
You must do make %{?_smp_mflags} in %check, or %make_build
Correct about the desktop file, but can you explain why %make_build in %check?
There are also warnings of unused-direct-shlib-dependency: The binary contains unused direct shared library dependencies. This may indicate gratuitously bloated linkage; check that the binary has been linked with the intended shared libraries only. svg2svgt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsvg2svgt.so.0.0.0 /lib64/libQt5Widgets.so.5 svg2svgt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsvg2svgt.so.0.0.0 /lib64/libQt5XmlPatterns.so.5 svg2svgt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsvg2svgt.so.0.0.0 /lib64/libQt5Gui.so.5 svg2svgt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsvg2svgt.so.0.0.0 /lib64/libQt5Network.so.5 https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency You can add this before calling cmake. (I have not tested it). export CXXFLAGS="%{optflags} -Wl,--as-needed"
(In reply to Sandro Mani from comment #3) > Correct about the desktop file, but can you explain why %make_build in > %check? I say to do: %check %make_build check because %make_build expands to: %{__make} -O %{?_smp_mflags} and this way you get parallel make to the number of cpus of the host.
Ah I see - in this case it won't do much good however since the check target is just a custom command executing a shell script.
Spec URL: https://smani.fedorapeople.org/review/svg2svgt.spec SRPM URL: https://smani.fedorapeople.org/review/svg2svgt-0.9.6-0.2.git5760c9d.fc28.src.rpm %changelog * Tue Aug 29 2017 Sandro Mani <manisandro> - 0.9.6-0.2.git5760c9d - Added desktop and appdata files - Add -Wl,--as-needed
The appdata file should go to %{_datadir}/appdata/ I prefer to use the parallel make in %check, although it only uses one process. When building in rawhide and F27, the debug info is kept at /usr/lib/.build-id in the main package. It looks like a bug in rpm, what do you think? $ rpmls svg2svgt-0.9.6-0.2.git5760c9d.fc28.x86_64.rpm -rwxr-xr-x /usr/bin/svg2svgt -rwxr-xr-x /usr/bin/svg2svgt-gui drwxr-xr-x /usr/lib/.build-id drwxr-xr-x /usr/lib/.build-id/2f lrwxrwxrwx /usr/lib/.build-id/2f/ad97a44a4c83172bec113138932aac4a2af21d drwxr-xr-x /usr/lib/.build-id/42 lrwxrwxrwx /usr/lib/.build-id/42/5bf406273e43af93c60b70d59cb673267cf0bd drwxr-xr-x /usr/lib/.build-id/61 lrwxrwxrwx /usr/lib/.build-id/61/07e1b5b317fad83c0ddc0d8c9c2aecfd4873e1 lrwxrwxrwx /usr/lib64/libsvg2svgt.so.0 -rwxr-xr-x /usr/lib64/libsvg2svgt.so.0.0.0 -rw-r--r-- /usr/share/applications/svg2svgt.desktop drwxr-xr-x /usr/share/doc/svg2svgt -rw-r--r-- /usr/share/doc/svg2svgt/README.md -rw-r--r-- /usr/share/icons/hicolor/64x64/apps/svg2svgt.png -rw-r--r-- /usr/share/icons/hicolor/scalable/apps/svg2svgt.svg drwxr-xr-x /usr/share/licenses/svg2svgt -rw-r--r-- /usr/share/licenses/svg2svgt/LICENSE.LGPL -rw-r--r-- /usr/share/metainfo/svg2svgt.appdata.xml drwxr-xr-x /usr/share/svg2svgt -rw-r--r-- /usr/share/svg2svgt/svg2svgt_en.qm -rw-r--r-- /usr/share/svg2svgt/svg2svgt_fi.qm $ rpmls svg2svgt-debuginfo-0.9.6-0.2.git5760c9d.fc28.x86_64.rpm drwxr-xr-x /usr/lib/debug drwxr-xr-x /usr/lib/debug/.build-id drwxr-xr-x /usr/lib/debug/.build-id/2f lrwxrwxrwx /usr/lib/debug/.build-id/2f/ad97a44a4c83172bec113138932aac4a2af21d lrwxrwxrwx /usr/lib/debug/.build-id/2f/ad97a44a4c83172bec113138932aac4a2af21d.debug drwxr-xr-x /usr/lib/debug/.build-id/42 lrwxrwxrwx /usr/lib/debug/.build-id/42/5bf406273e43af93c60b70d59cb673267cf0bd lrwxrwxrwx /usr/lib/debug/.build-id/42/5bf406273e43af93c60b70d59cb673267cf0bd.debug drwxr-xr-x /usr/lib/debug/.build-id/61 lrwxrwxrwx /usr/lib/debug/.build-id/61/07e1b5b317fad83c0ddc0d8c9c2aecfd4873e1 lrwxrwxrwx /usr/lib/debug/.build-id/61/07e1b5b317fad83c0ddc0d8c9c2aecfd4873e1.debug drwxr-xr-x /usr/lib/debug/.dwz -rw-r--r-- /usr/lib/debug/.dwz/svg2svgt-0.9.6-0.2.git5760c9d.fc28.x86_64 drwxr-xr-x /usr/lib/debug/usr drwxr-xr-x /usr/lib/debug/usr/bin -rw-r--r-- /usr/lib/debug/usr/bin/svg2svgt-0.9.6-0.2.git5760c9d.fc28.x86_64.debug -rw-r--r-- /usr/lib/debug/usr/bin/svg2svgt-gui-0.9.6-0.2.git5760c9d.fc28.x86_64.debug drwxr-xr-x /usr/lib/debug/usr/lib64 -rw-r--r-- /usr/lib/debug/usr/lib64/libsvg2svgt.so.0.0.0-0.9.6-0.2.git5760c9d.fc28.x86_64.debug juan@juan-laptop:~/Descargas$
From [1]: "As per appstream spec, /usr/share/metainfo/ is a successor to the /usr/share/appdata/ directory and the preferred location for installing appdata files." The build-id files originate from [2]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1434008 [2] https://fedoraproject.org/wiki/Changes/SubpackageAndSourceDebuginfo
Ok, so everything looks good, just use the parallel make in %check and I'll approve it.
Spec URL: https://smani.fedorapeople.org/review/svg2svgt.spec SRPM URL: https://smani.fedorapeople.org/review/svg2svgt-0.9.6-0.3.git5760c9d.fc28.src.rpm %changelog * Wed Aug 30 2017 Sandro Mani <manisandro> - 0.9.6-0.3.git5760c9d - Added %%{?_smp_mflags} to make check
Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in svg2svgt See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: svg2svgt-0.9.6-0.3.git5760c9d.fc26.x86_64.rpm svg2svgt-devel-0.9.6-0.3.git5760c9d.fc26.x86_64.rpm svg2svgt-debuginfo-0.9.6-0.3.git5760c9d.fc26.x86_64.rpm svg2svgt-0.9.6-0.3.git5760c9d.fc26.src.rpm svg2svgt.x86_64: W: no-manual-page-for-binary svg2svgt svg2svgt.x86_64: W: no-manual-page-for-binary svg2svgt-gui svg2svgt-devel.x86_64: W: only-non-binary-in-usr-lib svg2svgt-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: svg2svgt-debuginfo-0.9.6-0.3.git5760c9d.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory svg2svgt-devel.x86_64: W: only-non-binary-in-usr-lib svg2svgt-devel.x86_64: W: no-documentation svg2svgt.x86_64: W: no-manual-page-for-binary svg2svgt svg2svgt.x86_64: W: no-manual-page-for-binary svg2svgt-gui 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- svg2svgt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libsvg2svgt.so.0()(64bit) svg2svgt(x86-64) svg2svgt-debuginfo (rpmlib, GLIBC filtered): svg2svgt (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsvg2svgt.so.0()(64bit) rtld(GNU_HASH) Provides -------- svg2svgt-devel: pkgconfig(svg2svgt) svg2svgt-devel svg2svgt-devel(x86-64) svg2svgt-debuginfo: svg2svgt-debuginfo svg2svgt-debuginfo(x86-64) svg2svgt: application() application(svg2svgt.desktop) libsvg2svgt.so.0()(64bit) mimehandler(image/svg+xml) svg2svgt svg2svgt(x86-64) Source checksums ---------------- https://github.com/manisandro/svg2svgt/archive/5760c9d30e793de3d65475167ad1a0a652f3a16f/svg2svgt-5760c9d.tar.gz : CHECKSUM(SHA256) this package : 66f6aecef315c58da85a6b00a7bd0d52d48ce89a4dd1498ac56415dee9a27ddc CHECKSUM(SHA256) upstream package : 66f6aecef315c58da85a6b00a7bd0d52d48ce89a4dd1498ac56415dee9a27ddc Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1486278 Buildroot used: fedora-26-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thank you!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/svg2svgt