Red Hat Bugzilla – Bug 1486313
virt-manager shows a wrong Panic Notifier type
Last modified: 2018-04-10 07:43:30 EDT
Description of problem: When looking at "Panic Notifier" section of the "Virtual machine details" of a QEMU/KVM guest on s390x, the text says "Address Type: ISA" and "IO Base: 0x505". That does not make sense, since s390x does not have an ISA bus. Version-Release number of selected component (if applicable): virt-manager-1.4.1-7.el7.noarch libvirt-3.2.0-20.el7a.s390x qemu-kvm-2.9.0-7.p1.el7.s390x How reproducible: 100% Steps to Reproduce: 1. Create s390x guest 2. Open the "Virtual Machine Details" dialog 3. Have a look at the "Panic Notifier" pane Actual results: Address Type: ISA IO Base: 0X505 Expected results: Address Type: s390 Additional info: See https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=d855465452e978c3efe94d85ab107c066b40045d for some details about the panic pseudo device in libvirt
Similar problem exists in the "Add new virtual hardware" dialog: It offers to add a Panic Notifier with "Address Type: ISA" and "IO Base: XXX".
Upstream patches posted: https://www.redhat.com/archives/virt-tools-list/2017-September/msg00002.html
Upstream commits: commit 5f819aff97ba2973e8aca94b812ee32b85b404ca Author: Pavel Hrdina <phrdina@redhat.com> Date: Thu Aug 31 14:59:46 2017 +0200 virtinst: remove address configuration from panic device commit 9655f7dfaf9dc7665a19f1dfb72b7cade88d8d4b Author: Pavel Hrdina <phrdina@redhat.com> Date: Thu Aug 31 14:58:34 2017 +0200 virtManager: remove panic iobase from GUI commit 36230c9a187cba81cea7ecef23013feaee4124e5 Author: Pavel Hrdina <phrdina@redhat.com> Date: Mon Sep 4 18:40:34 2017 +0200 devicepanic: use model instead of address.type commit 48604bfb375e73b32abaa9f2b172f80549f0d949 Author: Pavel Hrdina <phrdina@redhat.com> Date: Mon Sep 4 18:44:56 2017 +0200 devicepanic: don't set default iobase commit 9f191da5c5d3789d57f81ad22eab3e82c72be65a Author: Pavel Hrdina <phrdina@redhat.com> Date: Tue Sep 5 09:38:39 2017 +0200 devicepanic: add all models supported by libvirt
This bug affect s390x, ppc64 and x86_64 as well. Before the fix virt-manager was displaying only ISA model and virt-install was able to configure only ISA model. The patches listed in Comment 4 fixes display issues in virt-manager and improves the panic configuration to select specific model. See <http://libvirt.org/formatdomain.html#elementsPanic> for the list of panic models.
Hardware: X86_64 I can reproduce this issue with build: virt-manager-1.4.1-7.el7.noarch virt-install-1.4.1-7.el7.noarch virt-manager-common-1.4.1-7.el7.noarch Steps: 1. List sub options supported by --panic # virt-install --panic=? --panic options: address.base address.bus address.controller address.cssid address.devno address.domain address.function address.iobase address.irq address.multifunction address.port address.reg address.slot address.ssid address.target address.type address.unit clearxml iobase 2. Create a guest with attaching a panic notifier device # virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/x86_64/os/ 3. Check guest xml <panic model='isa'> <address type='isa' iobase='0x505'/> </panic> Result: It has address configuration for panic device. 4. Also check virt-manager GUI for "Panic Notifier" pane Address Type: ISA IO Base: 0X505 Result: It also shows address configuration Then try to verify this bug with new build: virt-manager-1.4.3-1.el7.noarch virt-install-1.4.3-1.el7.noarch virt-manager-common-1.4.3-1.el7.noarch Steps: 1. List sub options supported by --panic # virt-install --panic=? --panic options: clearxml iobase model Result: Removing address configuration from panic device, it is expected. 2. Create a guest with attaching a panic notifier device # virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/x86_64/os/ 3. Check guest xml ... <panic model='isa'/> ... Result: Using model instead of address.type, it is expected. 4. Also check virt-manager GUI for "Panic Notifier" pane Model: ISA Result: 4.1 Using model instead of address.type and panic iobase has removed from GUI, it is expected result. 4.2 And we can find another panic model is listed as 'Hyper-V' on adding new panic notifier page. @Pavel, I. iobase has removed from GUI, why not exists in Step1 result. Is it duing to commit 48604bfb375e73b32abaa9f2b172f80549f0d949, right? II. Based on Comment 5, do you suggest do some related testing on s390x and ppc64 hardwares, thanks.
Yes, the iobase was removed from GUI because of that commit, that change is correct. If you have resources to test it on s390x and ppc64 hardware, it would be nice to test it there.
Verify on Hardware: ppc64 Version: virt-install-1.4.3-1.el7.noarch Steps: 1. List sub options supported by --panic # virt-install --panic=? --panic options: clearxml iobase model Result: Removing address configuration from panic device, it is expected. 2. Create a guest with attaching a panic notifier device # virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/ppc64/os/ 3. Check guest xml ... <panic model='pseries'/> ... Result: Using model instead of address.type, it is expected. So it works well on ppc64 hardware.
Verify on hardware: s390x Install Host os with DISTRO=RHEL-ALT-7.5-20171120.n.0 Steps: 1. Install virt-manager/virt-install/virt-manager-common releated packages on s390x system virt-manager-1.4.3-1.el7.noarch virt-install-1.4.3-1.el7.noarch virt-manager-common-1.4.3-1.el7.noarch python-ipaddr-2.1.11-1.el7.noarch 2. List sub options supported by --panic # virt-install --panic=? --panic options: clearxml iobase model Result: No address configuration lists for panic device, it is as expected. 3. Create a guest with attaching a panic notifier device # virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=raw --graphics vnc --panic default --location http://download.eng.bos.redhat.com/nightly/RHEL-ALT-7.5-20171113.n.0/compose/Server/s390x/os 4. Check guest xml to find configuration for panic device. # virsh dumpxml test-panic ... <panic model='s390'/> ... Result: Selects 's390' as default panic model for S390 guest, it is as expected. So based on Comment 8 and Comment 9, move this bug from ON_QA status to VERIFIED status, thanks.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:0726