Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1486313

Summary: virt-manager shows a wrong Panic Notifier type
Product: Red Hat Enterprise Linux 7 Reporter: Thomas Huth <thuth>
Component: virt-managerAssignee: Pavel Hrdina <phrdina>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.5CC: areis, cohuck, dhildenb, gsun, hannsj_uhl, juzhou, kuwei, mxie, phrdina, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-1.4.3-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 11:43:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1471761    

Description Thomas Huth 2017-08-29 13:00:59 UTC 
Description of problem:
When looking at "Panic Notifier" section of the "Virtual machine details" of a QEMU/KVM guest on s390x, the text says "Address Type: ISA" and "IO Base: 0x505". That does not make sense, since s390x does not have an ISA bus.

Version-Release number of selected component (if applicable):
virt-manager-1.4.1-7.el7.noarch
libvirt-3.2.0-20.el7a.s390x
qemu-kvm-2.9.0-7.p1.el7.s390x

How reproducible:
100%

Steps to Reproduce:
1. Create s390x guest
2. Open the "Virtual Machine Details" dialog
3. Have a look at the "Panic Notifier" pane

Actual results:
 Address Type: ISA
 IO Base: 0X505

Expected results:
 Address Type: s390

Additional info:
See https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=d855465452e978c3efe94d85ab107c066b40045d for some details about the panic pseudo device in libvirt
Comment 2 Thomas Huth 2017-08-29 13:05:14 UTC 
Similar problem exists in the "Add new virtual hardware" dialog: It offers to add a Panic Notifier with "Address Type: ISA" and "IO Base: XXX".
Comment 3 Pavel Hrdina 2017-09-05 13:47:18 UTC 
Upstream patches posted:

https://www.redhat.com/archives/virt-tools-list/2017-September/msg00002.html
Comment 4 Pavel Hrdina 2017-09-11 07:34:15 UTC 
Upstream commits:

commit 5f819aff97ba2973e8aca94b812ee32b85b404ca
Author: Pavel Hrdina <phrdina>
Date:   Thu Aug 31 14:59:46 2017 +0200

    virtinst: remove address configuration from panic device

commit 9655f7dfaf9dc7665a19f1dfb72b7cade88d8d4b
Author: Pavel Hrdina <phrdina>
Date:   Thu Aug 31 14:58:34 2017 +0200

    virtManager: remove panic iobase from GUI

commit 36230c9a187cba81cea7ecef23013feaee4124e5
Author: Pavel Hrdina <phrdina>
Date:   Mon Sep 4 18:40:34 2017 +0200

    devicepanic: use model instead of address.type

commit 48604bfb375e73b32abaa9f2b172f80549f0d949
Author: Pavel Hrdina <phrdina>
Date:   Mon Sep 4 18:44:56 2017 +0200

    devicepanic: don't set default iobase

commit 9f191da5c5d3789d57f81ad22eab3e82c72be65a
Author: Pavel Hrdina <phrdina>
Date:   Tue Sep 5 09:38:39 2017 +0200

    devicepanic: add all models supported by libvirt
Comment 5 Pavel Hrdina 2017-09-20 10:51:10 UTC 
This bug affect s390x, ppc64 and x86_64 as well.  Before the fix virt-manager was displaying only ISA model and virt-install was able to configure only ISA model.  The patches listed in Comment 4 fixes display issues in virt-manager and improves the panic configuration to select specific model.

See <http://libvirt.org/formatdomain.html#elementsPanic> for the list of panic models.
Comment 7 zhoujunqin 2017-09-28 10:14:26 UTC 
Hardware: X86_64

I can reproduce this issue with build:
virt-manager-1.4.1-7.el7.noarch
virt-install-1.4.1-7.el7.noarch
virt-manager-common-1.4.1-7.el7.noarch

Steps:
1. List sub options supported by --panic
# virt-install --panic=?
--panic options:
  address.base
  address.bus
  address.controller
  address.cssid
  address.devno
  address.domain
  address.function
  address.iobase
  address.irq
  address.multifunction
  address.port
  address.reg
  address.slot
  address.ssid
  address.target
  address.type
  address.unit
  clearxml
  iobase
 
2. Create a guest with attaching a panic notifier device
# virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/x86_64/os/

3. Check guest xml
    <panic model='isa'>
      <address type='isa' iobase='0x505'/>
    </panic>

Result: It has address configuration for panic device.

4. Also check virt-manager GUI for "Panic Notifier" pane
 Address Type: ISA
 IO Base: 0X505

Result: It also shows address configuration


Then try to verify this bug with new build:
virt-manager-1.4.3-1.el7.noarch
virt-install-1.4.3-1.el7.noarch
virt-manager-common-1.4.3-1.el7.noarch

Steps:

1. List sub options supported by --panic
# virt-install --panic=?
--panic options:
  clearxml
  iobase
  model

Result: Removing address configuration from panic device,  it is expected.

 
2. Create a guest with attaching a panic notifier device
# virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/x86_64/os/

3. Check guest xml
...
    <panic model='isa'/>
...

Result: Using model instead of address.type, it is expected.

4. Also check virt-manager GUI for "Panic Notifier" pane
 Model: ISA

Result: 
4.1 Using model instead of address.type and panic iobase has removed from GUI, it is expected result.
4.2 And we can find another panic model is listed as 'Hyper-V' on adding new panic notifier page.

@Pavel,
I. iobase has removed from GUI, why not exists in Step1 result.
   Is it duing to commit 48604bfb375e73b32abaa9f2b172f80549f0d949, right?
II. Based on Comment 5, do you suggest do some related testing on s390x and ppc64 hardwares, thanks.
Comment 8 Pavel Hrdina 2017-10-02 08:20:02 UTC 
Yes, the iobase was removed from GUI because of that commit, that change is correct.

If you have resources to test it on s390x and ppc64 hardware, it would be nice to test it there.
Comment 9 zhoujunqin 2017-10-09 10:23:18 UTC 
Verify on Hardware: ppc64

Version:
virt-install-1.4.3-1.el7.noarch

Steps:
1. List sub options supported by --panic
# virt-install --panic=?
--panic options:
  clearxml
  iobase
  model

Result: Removing address configuration from panic device,  it is expected.

2. Create a guest with attaching a panic notifier device
# virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=qcow2 --graphics vnc --panic default --location http://download.eng.pek2.redhat.com/pub/rhel/released/RHEL-7/7.4/Server/ppc64/os/

3. Check guest xml
...
    <panic model='pseries'/>
...

Result: Using model instead of address.type, it is expected.

So it works well on ppc64 hardware.
Comment 10 zhoujunqin 2017-11-20 09:01:57 UTC 
Verify on hardware: s390x
Install Host os with DISTRO=RHEL-ALT-7.5-20171120.n.0

Steps:
1. Install virt-manager/virt-install/virt-manager-common releated packages on s390x system

virt-manager-1.4.3-1.el7.noarch
virt-install-1.4.3-1.el7.noarch
virt-manager-common-1.4.3-1.el7.noarch
python-ipaddr-2.1.11-1.el7.noarch


2. List sub options supported by --panic
# virt-install --panic=?
--panic options:
  clearxml
  iobase
  model

Result: No address configuration lists for panic device, it is as expected.

3. Create a guest with attaching a panic notifier device
# virt-install --name test-panic --memory 1024 --disk path=/tmp/test-panic.img,size=8,format=raw  --graphics vnc --panic default --location http://download.eng.bos.redhat.com/nightly/RHEL-ALT-7.5-20171113.n.0/compose/Server/s390x/os

4. Check guest xml to find configuration for panic device.

# virsh dumpxml test-panic
...
    <panic model='s390'/>
...

Result: Selects 's390' as default panic model for S390 guest, it is as expected.

So based on Comment 8 and Comment 9, move this bug from ON_QA status to VERIFIED status, thanks.
Comment 13 errata-xmlrpc 2018-04-10 11:43:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0726