Bug 1486592 - Review Request: ghc-concurrent-output - Ungarble output from several threads or commands
Summary: Review Request: ghc-concurrent-output - Ungarble output from several threads ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1485512
Blocks: 1491457
TreeView+ depends on / blocked
 
Reported: 2017-08-30 08:21 UTC by Elliott Sales de Andrade
Modified: 2017-11-18 23:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-21 23:53:07 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2017-08-30 08:21:39 UTC
Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-concurrent-output.spec
SRPM URL: https://qulogic.fedorapeople.org/git-annex/ghc-concurrent-output-1.10.0-1.git.146.9f546a1.fc26.src.rpm
Description: Lets multiple threads and external processes concurrently output to the console, without it getting all garbled up.
Fedora Account System Username: qulogic

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21546314

Comment 1 Elliott Sales de Andrade 2017-08-30 08:22:41 UTC
This needs a new version of ghc-process, so I need to poke someone about that first.

Comment 2 Robert-André Mauchin 🐧 2017-08-30 09:53:14 UTC
ghc-process is a subpackage of ghc. Latest upstream version 8.2.1 was published on July the 22nd, while we have the previous version, 8.0.2, in Rawhide.
You need to poke petersen https://fedoraproject.org/wiki/User:Petersen probably by filing a bug report against ghc-process https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide&component=ghc-process

Comment 3 Elliott Sales de Andrade 2017-08-31 07:13:14 UTC
If we need a full new ghc just to get a new ghc-process, that might be a bit too much work. WDYT, Jens?

If ghc-process needs a full upgrade of everything, then I can package 1.9.2 of concurrent-output, which is basically the same as 1.10.0 but with the workaround to continue working with the older ghc-process.

Whatever the case for Rawhide, I'd guess that F26 would never get this large of an upgrade (if full a ghc bump is required), so I'd probably still have to do that anyway.

Comment 4 Jens Petersen 2017-09-11 10:44:59 UTC
Please follow the versioning of Stackage LTSHaskell.

I don't think we are ready to move Rawhide to 8.2.1 yet.

Comment 5 Elliott Sales de Andrade 2017-09-12 00:51:36 UTC
Here is the previous release. As I mentioned before, it's basically the same but with the requirement for the new version of ghc-process.

Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-concurrent-output.spec
SRPM URL: https://qulogic.fedorapeople.org/git-annex/ghc-concurrent-output-1.9.2-2.git.0.1f88391.fc26.src.rpm
Description: Lets multiple threads and external processes concurrently output to the console, without it getting all garbled up.
Fedora Account System Username: qulogic

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21804787

Comment 6 Robert-André Mauchin 🐧 2017-09-12 01:26:44 UTC
Good to go, package accepted.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated". 8 files have unknown
     license. Detailed output of licensecheck in /home/bob/packaging/review
     /ghc-concurrent-output/review-ghc-concurrent-output/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 296960 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Comment 7 Gwyn Ciesla 2017-09-12 12:19:16 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-concurrent-output

Comment 8 Fedora Update System 2017-09-12 21:52:09 UTC
ghc-concurrent-output-1.9.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-50d50823cd

Comment 9 Fedora Update System 2017-09-12 21:52:45 UTC
ghc-concurrent-output-1.9.2-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-611d5e7c31

Comment 10 Fedora Update System 2017-09-13 19:24:03 UTC
ghc-concurrent-output-1.9.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-50d50823cd

Comment 11 Fedora Update System 2017-09-14 04:52:30 UTC
ghc-concurrent-output-1.9.2-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-611d5e7c31

Comment 12 Fedora Update System 2017-09-21 23:53:07 UTC
ghc-concurrent-output-1.9.2-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-09-30 06:26:49 UTC
ghc-concurrent-output-1.9.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.