Bug 1486761 - [UI] cloud-init: improve networking text
Summary: [UI] cloud-init: improve networking text
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.1
: ---
Assignee: eraviv
QA Contact: Vitalii Yerys
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-30 13:48 UTC by Nisim Simsolo
Modified: 2018-05-31 02:31 UTC (History)
8 users (show)

Fixed In Version: upstream 4.2.1
Clone Of:
Environment:
Last Closed: 2018-02-12 11:56:21 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: planning_ack+
rule-engine: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)
cloud-init network (198.83 KB, image/png)
2017-08-30 14:10 UTC, Nisim Simsolo
no flags Details
Solution (176.17 KB, image/jpeg)
2017-09-05 15:50 UTC, Eldan Hildesheim
no flags Details
new ux for run once / network (194.24 KB, image/jpeg)
2017-10-03 09:22 UTC, Eldan Hildesheim
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 83939 0 None None None 2017-11-26 15:05:37 UTC
oVirt gerrit 85531 0 master MERGED webadmin: change label of cloud-init network drop-down - take 2 2017-12-19 09:19:11 UTC

Description Nisim Simsolo 2017-08-30 13:48:06 UTC
Description of problem:
When editing VM -> initial run -> cloud-init network, there is a combination of dropbox/textbox (which is the same field that should set the interface name) without any description of what this field is used for.
When trying to confirm network setting and leaving this field empty, the field frame is marked red with "this field can't be empty" message, still it's unclear what is the meaning of this field.

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.6-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Browse webadmin -> VMs tab -> edit VM -> initial run -> check use cloud-init/sysprep checkbox -> check network checkbox.
2. Try to set static IP configuration without filling the textbox/dropbox near network.
3.

Actual results:
Action rejected with  "this field can't be empty" message.

Expected results:
It should be mentioned what this field should be filled with before and after the action is rejected by webadmin.

Additional info:
Screenshot attached

Comment 1 Nisim Simsolo 2017-08-30 14:10:03 UTC
Created attachment 1320107 [details]
cloud-init network

Comment 2 Dan Kenigsberg 2017-09-02 21:19:31 UTC
Eldan, where would you place a text that should convey "guest-side interface name" ? And can you find a better text?

Comment 3 Eldan Hildesheim 2017-09-05 15:49:20 UTC
Dan is right, just adding a line like in the mock up will solve the problem.

Generally speaking this Tab looks very bad. Please add some indents like in the mock up. 

It could also be a good opportunity to change the widgets according PatternFly (again check mock up)

Here are the references and the code for each area in this modal:

http://www.patternfly.org/pattern-library/forms-and-controls/expand-collapse-section/

http://www.patternfly.org/pattern-library/forms-and-controls/errors-and-validation/

http://www.patternfly.org/pattern-library/forms-and-controls/data-input/

Comment 4 Eldan Hildesheim 2017-09-05 15:50:15 UTC
Created attachment 1322260 [details]
Solution

Comment 5 eraviv 2017-09-26 08:45:47 UTC
Nissim,

Please confirm that the following message is valid:

"Enter in-guest interface name or select to edit"

Comment 6 eraviv 2017-09-26 08:57:37 UTC
Eldan,

Please confirm that the following message is valid:
"Enter in-guest interface name or select to edit"

Also, since redoing the widget is out of scope for a defect, I suggest to just change the text for now, and open a separate user story for the other requirements. Is that ok?

Thanks

Comment 7 Eldan Hildesheim 2017-10-03 09:22:00 UTC
Created attachment 1333567 [details]
new ux for run once / network

Comment 8 Eldan Hildesheim 2017-10-03 09:31:35 UTC
After talking with Eitan Raviv, I came to understand that the UX.
In the latest mockup I did (new ux for run once / network ) I fixed the scenario.
- All the networks are spread in front of the user. 
- The equivalent to the "none" in the dropdown which was not understood was changed: now there are 2 checkboxes for enabling/disabling IPv4 and IPv6.

Comment 9 Yaniv Lavi 2017-11-26 14:53:05 UTC
Isn't this fixed in 4.2?

Comment 10 Dan Kenigsberg 2017-11-26 15:05:38 UTC
Let bug 1422784 track the request to re-do the network UX of cloud-init, and this bug should be limited to the labeling alone.

Comment 11 eraviv 2017-12-20 12:20:42 UTC
returning to status modified because there is no d/s for this for now

Comment 12 Nisim Simsolo 2018-01-10 15:11:32 UTC
Verified using rhvm-4.2.1-0.2.el7
edit VM -> initial run -> cloud init is now equal to the solution attached in this bug.

Comment 13 Sandro Bonazzola 2018-02-12 11:56:21 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.