Bug 1487064 - ERROR (Thread-1) [utils.Callback] qemuGuestAgentCallback failed on VM shutdown
Summary: ERROR (Thread-1) [utils.Callback] qemuGuestAgentCallback failed on VM shutdown
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: x86_64
OS: Linux
medium
low
Target Milestone: ovirt-4.2.0
: ---
Assignee: Tomáš Golembiovský
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-31 08:03 UTC by Michael Burman
Modified: 2017-12-20 10:48 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:48:37 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
vdsm log (978.38 KB, application/x-gzip)
2017-08-31 08:03 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 81941 0 master ABANDONED virt: fix error handling of QGA power cycle commands 2017-10-12 12:59:18 UTC
oVirt gerrit 82709 0 master MERGED virt: powerdown: fix qemuGuestAgent usage 2017-10-13 09:58:40 UTC

Description Michael Burman 2017-08-31 08:03:54 UTC
Created attachment 1320492 [details]
vdsm log

Description of problem:
ERROR (Thread-1) [utils.Callback] qemuGuestAgentCallback failed on VM shutdown.

On every VM shutdown this error messages appears in vdsm log - 

2017-08-31 10:53:38,568+0300 INFO  (jsonrpc/1) [jsonrpc.JsonRpcServer] RPC call VM.shutdown succeeded in 0.00 seconds (__init__:630)
2017-08-31 10:53:38,736+0300 ERROR (Thread-1) [utils.Callback] qemuGuestAgentCallback failed (utils:345)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 343, in __call__
    result = self.func(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vmpowerdown.py", line 107, in qemuGuestAgentCallback
    if response.is_error(self.vm.qemuGuestAgentShutdown()):
  File "/usr/lib/python2.7/site-packages/vdsm/common/response.py", line 79, in is_error
    code = res["status"]["code"]
TypeError: 'NoneType' object has no attribute '__getitem__'
2017-08-31 10:53:39,715+0300 INFO  (jsonrpc/5) [jsonrpc.JsonRpcServer] RPC call Host.setKsmTune succeeded in 0.00 seconds (__init__:630)

Version-Release number of selected component (if applicable):
4.2.0-0.0.master.20170828065003.git0619c76.el7.centos
vdsm-4.20.2-132.git936e6cc.el7.centos.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Run VM
2. Shutdown VM
3. Check vdsm.log

Actual results:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 343, in __call__
    result = self.func(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vmpowerdown.py", line 107, in qemuGuestAgentCallback
    if response.is_error(self.vm.qemuGuestAgentShutdown()):
  File "/usr/lib/python2.7/site-packages/vdsm/common/response.py", line 79, in is_error
    code = res["status"]["code"]
TypeError: 'NoneType' object has no attribute '__getitem__'

Expected results:
No errors on VM shutdown

Comment 1 Michal Skrivanek 2017-09-01 05:17:56 UTC
What do you run inside that guest? Is it fully booted and responsive?

Comment 2 Michael Burman 2017-09-01 09:09:04 UTC
(In reply to Michal Skrivanek from comment #1)
> What do you run inside that guest? Is it fully booted and responsive?

I'm running rhel7.2 guests, nothing special running on it, it is fully booted and responsive.
I see this errors on every VM shutdown.

Comment 3 Michal Skrivanek 2017-09-01 09:13:40 UTC
nothing special means you have ovirt-guest-agent and qemu-guest-agent installed and running or not?

Comment 4 Michal Skrivanek 2017-09-01 09:23:48 UTC
please check the return value in the call introduced in I751a3f0ae0db7dcf6da01ca949906a4d3947ba85

Comment 5 Michael Burman 2017-09-01 09:30:20 UTC
(In reply to Michal Skrivanek from comment #3)
> nothing special means you have ovirt-guest-agent and qemu-guest-agent
> installed and running or not?

Sorry for not being clear, yes i do have ovirt-guest-agent and qemu-guest-agent installed and running - 

ovirt-guest-agent-common-1.0.13-2.el7ev.noarch
qemu-guest-agent-2.5.0-3.el7.x86_64

Comment 6 Michal Skrivanek 2017-09-01 10:32:42 UTC
great. thanks

Tomas, comment #4 please

Comment 7 Tomáš Golembiovský 2017-09-18 14:14:35 UTC
The fix is on the way.

Comment 8 Yaniv Kaul 2017-10-15 13:02:59 UTC
Are there any additional patches needed here, or can this move to MODIFIED?

Comment 9 Israel Pinto 2017-11-14 08:30:13 UTC
Verify with:
Software version:4.2.0-0.0.master.20171108151837.gita7de53e.el7.centos


Steps:
1. Create VM with OS and guest agent
2. RUn VM 
3. Do the 3 actions of: stop, reboot, suspend 
4. check vdsm log

Results:
All actions done with success, no errors found in vdsm log

Comment 10 Sandro Bonazzola 2017-12-20 10:48:37 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.