Spec URL: https://hadess.fedorapeople.org/emoji/eosrei-emojione-fonts.spec SRPM URL: https://hadess.fedorapeople.org/emoji/eosrei-emojione-fonts-1.0-3.fc26.src.rpm Description: A color and B&W emoji font built primarily from Emoji One artwork with support for ZWJ, skin tone modifiers and country flags. Regular B&W outline emoji are included for backwards/fallback compatibility. It was created by Brad Erickson. Fedora Account System Username: hadess A few notes. We'd like to use this as the default emoji font for GNOME, as the GNOME stack recently got support for (some types of) colour fonts, and changes were made in cairo, pango, fontconfig and gtk+ to support this new functionality. This version of the font is the last one that's available under a free license. When the build system for the font variants that we support is sorted out, we'll likely move to "Emoji Two" a free fork of the "Emoji One" font.
All the font-specific stuff seems fine to me (I checked the .ttf with "ttname -a" to verify the licensing). Bastien discussed some concerns on IRC, including: * the fontconfig release containing the config file bits is not out yet, so a dependency on that version may be wise * a cairo release containing the necessary improvements for colour emoji support (1.15.8) is not yet in Fedora, similar consideration to the fontconfig dependency Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [x]: Run ttname on all fonts in package. Rpmlint ------- Checking: eosrei-emojione-fonts-1.0-3.fc28.src.rpm eosrei-emojione-fonts.src: W: spelling-error Summary(en_US) emoji -> emotive eosrei-emojione-fonts.src: W: spelling-error %description -l en_US emoji -> emotive eosrei-emojione-fonts.src: W: invalid-license CC-BY-4.0 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- Provides -------- Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1487123 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, fonts, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
-4 version available at: https://hadess.fedorapeople.org/emoji/ I'm not sure we should add the cairo/fontconfig/pango dependencies, as the font will still "work" if those aren't around, it'll just trigger bugs in various places.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/eosrei-emojione-fonts
eosrei-emojione-fonts-1.0-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9009714eb
eosrei-emojione-fonts-1.0-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9009714eb
1) I am not sure if something is wrong on my f27 system but following does not give any output to me whereas all other fonts are giving some output. sudo dnf repoquery --provides eosrei-emojione-fonts sudo dnf repoquery --requires eosrei-emojione-fonts 2) Good to add appstream metainfo file for this font like we have this /usr/share/appdata/abattis-cantarell.metainfo.xml
(In reply to Parag AN(पराग) from comment #6) > 1) I am not sure if something is wrong on my f27 system but following does > not give any output to me whereas all other fonts are giving some output. > > sudo dnf repoquery --provides eosrei-emojione-fonts > sudo dnf repoquery --requires eosrei-emojione-fonts $ rpm -q --provides eosrei-emojione-fonts eosrei-emojione-fonts = 1.0-4.fc27 font(emojione) As expected. > 2) Good to add appstream metainfo file for this font like we have this > /usr/share/appdata/abattis-cantarell.metainfo.xml Can you please file a separate bug about this?
(In reply to Bastien Nocera from comment #7) > (In reply to Parag AN(पराग) from comment #6) > > 2) Good to add appstream metainfo file for this font like we have this > > /usr/share/appdata/abattis-cantarell.metainfo.xml > > Can you please file a separate bug about this? FWIW, I'm not really sure of why we'd need that when both cantarell and emojione are pulled in by portion of our default desktop.
Thanks for confirming output of requires/provides. For metainfo file here is the new bug -> https://bugzilla.redhat.com/show_bug.cgi?id=1491265
(In reply to Bastien Nocera from comment #8) > (In reply to Bastien Nocera from comment #7) > > (In reply to Parag AN(पराग) from comment #6) > > > 2) Good to add appstream metainfo file for this font like we have this > > > /usr/share/appdata/abattis-cantarell.metainfo.xml > > > > Can you please file a separate bug about this? > > FWIW, I'm not really sure of why we'd need that when both cantarell and > emojione are pulled in by portion of our default desktop. Hm, You are right. I am not sure if this can be a new topic of discussion. We have almost all fonts providing metainfo files and then some fonts are already present in default desktop installation. Not sure if we want to remove metainfo files from them.
eosrei-emojione-fonts-1.0-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f
eosrei-emojione-fonts-1.0-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f
eosrei-emojione-fonts-1.0-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.