Spec URL: https://raw.githubusercontent.com/erigones/zabbix-api/master/rpmbuild/SPECS/python-zabbix-api-erigones.spec SRPM URL: https://github.com/erigones/zabbix-api/raw/master/rpmbuild/SRPMS/python-zabbix-api-erigones-1.2.4-1.fc26.src.rpm Zabbix API Python Library. Used by the Ludolph Monitoring Jabber Bot. * Supported Python versions: >= 2.6 and >= 3.2 * Supported Zabbix versions: 1.8, 2.0, 2.2, 2.4, 3.0 Fedora Account System Username: ricco I am a co-creator of this library and also an active developer and a package maintainer at GitHub. Repository: https://github.com/erigones/zabbix-api This is pure Python library to communicate with Zabbix server API. It is used in Ludolph project (my another package under review: https://bugzilla.redhat.com/show_bug.cgi?id=1484561) for connection with Zabbix. But this project can be used as a stand alone library for communication with Zabbix API. Koji builds: f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=21592893 f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21593366 f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=21593526 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21592161 Current version 1.2.4. has not been released on PyPI yet. I will release (and tag) it after this review (in case I have to update the spec with errors found during the review).
Hello, The latest version displayed here https://pypi.python.org/pypi/zabbix-api-erigones is 1.2.3. I can't find version 1.2.4 even on Github, your Source0 is 404ing because of that. With the version 1.2.3, the build fails with: error: File not found: /builddir/build/BUILDROOT/python-zabbix-api-erigones-1.2.3-1.fc28.x86_64/usr/share/licenses/python2-zabbix-api-erigones/LICENSE I suggest you add the LICENSE as a Source1: Source1: https://raw.githubusercontent.com/erigones/zabbix-api/master/LICENSE Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/zabbix-api-erigones/review-python-zabbix- api-erigones/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -zabbix-api-erigones , python3-zabbix-api-erigones [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-zabbix-api-erigones-1.2.3-1.fc28.noarch.rpm python3-zabbix-api-erigones-1.2.3-1.fc28.noarch.rpm python-zabbix-api-erigones-1.2.3-1.fc28.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thank you for the review. Yes, 1.2.3 had a bug that it was not distributed with a LICENSE file. That I have fixed in 1.2.4. I have mentioned it at the end of the bug that 1.2.4 has not been released on PyPI yet. So I assume you have tried to download it with spectool, and that is why you got 404. Sorry, I should have released it anyway, to avoid confusion. I was waiting if there would be something to fix in the spec so 1.2.4 matches the spec on GitHub, sorry about that. I have done the release of 1.2.4 and on PyPI should work for you without any issues. Build done from 1.2.4 has a LICENSE file distributed properly: <mock-chroot> sh-4.4# ll /usr/share/licenses/python3-zabbix-api-erigones/ total 0 -rw-r--r--. 1 root root 26462 Aug 31 15:33 LICENSE <mock-chroot> sh-4.4# ll /usr/share/licenses/python2-zabbix-api-erigones/ total 0 -rw-r--r--. 1 root root 26462 Aug 31 15:33 LICENSE Koji builds: f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=21611400 f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21611440 f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=21611479 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21611489
> Supported Python versions: >= 2.6 and >= 3.2 Not sure if this is useful in the package description.
Sorry I should have read the post until the end instead of just firing up fedora-review on the bug number. Everything is good, package accepted.
Sorry, I had to amend bug summary in order to make it work with fedrepo-req.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-zabbix-api-erigones. You may create the branch "f26" using git in about 10 minutes.
python-zabbix-api-erigones-1.2.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3abac527af
python-zabbix-api-erigones-1.2.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3abac527af
python-zabbix-api-erigones-1.2.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8baf73bad5
python-zabbix-api-erigones-1.2.4-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d2cb5a6ce
python-zabbix-api-erigones-1.2.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d2cb5a6ce
python-zabbix-api-erigones-1.2.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8baf73bad5
python-zabbix-api-erigones-1.2.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
python-zabbix-api-erigones-1.2.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-zabbix-api-erigones-1.2.4-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.