Bug 1487596 - Update the generated gdeploy config script to halt the installation if blacklisting all the disks fails
Summary: Update the generated gdeploy config script to halt the installation if blackl...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.10.7-0.0.23
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.1.6
: ---
Assignee: Gobinda Das
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-01 11:06 UTC by SATHEESARAN
Modified: 2017-09-19 10:02 UTC (History)
2 users (show)

Fixed In Version: cockpit-ovirt-0.10.8-2.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-19 10:02:30 UTC
oVirt Team: Gluster
Embargoed:
sasundar: ovirt-4.1?
sasundar: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 81448 0 master POST Updated ovirt-gluster-hc.conf to halt the installation if blacklisting all the disks fails 2017-09-05 10:02:37 UTC
oVirt gerrit 81457 0 ovirt-4.1 POST Updated ovirt-gluster-hc.conf to halt the installation if blacklisting all the disks fails 2017-09-05 12:01:59 UTC
oVirt gerrit 81458 0 ovirt-4.2 POST Updated ovirt-gluster-hc.conf to halt the installation if blacklisting all the disks fails 2017-09-05 12:03:41 UTC

Description SATHEESARAN 2017-09-01 11:06:35 UTC
Description of problem:
------------------------
update the generated gdeploy config file to halt the installation, when blacklisting all the disks fails.

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
cockpit-ovirt-dashboard-0.10.7-0.0.23

How reproducible:
-----------------
Always

Steps to Reproduce:
--------------------
1. Start multipathd on the host
2. Run the cockpit installation for RHHI deployment

Actual results:
---------------
RHHI installation continues with mpath names in place

Expected results:
-----------------
RHHI installation should fail at the place, when blacklisting all the disks fails

Additional info:
-----------------
The gdeploy template file ('/usr/share/cockpit/ovirt-dashboard/gdeploy-templates/ovirt-gluster-hc.conf') needs the following modification:

<actual>
# Blacklist devices in multipath.conf
[script3]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-multipath.sh
</actual>

<expected>
# Blacklist devices in multipath.conf
[script3]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-multipath.sh
ignore_script_errors=no
</expected>

Comment 1 SATHEESARAN 2017-09-01 11:10:23 UTC
RHHI installation is intentially failed when gdeploy script 'blacklist_all_disks.sh' fails

Comment 2 SATHEESARAN 2017-09-14 11:01:23 UTC
Tested with cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch

With the failure of the script that blacklists all the local devices, gdeploy halts the execution.

The generated gdeploy conf file that calls the script to blacklist local devices is updated as below:

[script3]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-multipath.sh
ignore_script_errors=no


Note You need to log in before you can comment on or make changes to this bug.