Spec URL: https://ppisar.fedorapeople.org/dontpanic/dontpanic.spec SRPM URL: https://ppisar.fedorapeople.org/dontpanic/dontpanic-1.00-1.fc28.src.rpm Description: This software provides a very simple library and executable used in testing Alien::Base. Fedora Account System Username: ppisar
Hello, Please use a more meaningful name for your archive: Source0: https://github.com/Perl5-Alien/dontpanic/archive/%{version}/%{name}-%{version}.tar.gz - make and findutils are not needed as BR. - dontpanic contains an rpath: dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic ['/builddir/build/BUILD/dontpanic-1.00/src/.libs'] You need to remove it, see https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make findutils See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/dontpanic/review- dontpanic/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(powerline- go), /usr/lib64/pkgconfig(pkgconf-pkg-config) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dontpanic-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dontpanic-1.00-1.fc28.x86_64.rpm dontpanic-devel-1.00-1.fc28.x86_64.rpm dontpanic-debuginfo-1.00-1.fc28.x86_64.rpm dontpanic-1.00-1.fc28.src.rpm dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic ['/builddir/build/BUILD/dontpanic-1.00/src/.libs'] dontpanic.x86_64: W: no-documentation dontpanic.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dontpanic.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dontpanic.x86_64: W: no-manual-page-for-binary dontpanic dontpanic-devel.x86_64: W: only-non-binary-in-usr-lib dontpanic-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 6 warnings.
(In reply to Robert-André Mauchin from comment #1) > Please use a more meaningful name for your archive: > > Source0: > https://github.com/Perl5-Alien/dontpanic/archive/%{version}/%{name}- > %{version}.tar.gz > Thank you for the address. I will used it in the updated spec file. > - make and findutils are not needed as BR. > They are called from the spec file. They are needed. > - dontpanic contains an rpath: > > dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic > ['/builddir/build/BUILD/dontpanic-1.00/src/.libs'] > Exactly for the reason I deleted Makefile.in files. Probably something changed in the build root and now even the regenerated files contain the -rpath option. I still cannot figure what caused the change. > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: make findutils > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 There is no exception list.
I could found what has changed, but I found what triggers adding the -rpath option. It was disabling static linking via ./configure --disable-static and forcing static linking via libtool -static at the same time. I patched the src/Makefile.am not to force the static linking. Updated package is on the same addresses.
(In reply to Petr Pisar from comment #3) > I could found what has changed I could not find.
Hello, There are some obsoletes macros in configure: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AM_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:15 AC_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:14 These need to be patched with LT_INIT. See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html for further details. Here's a patch: diff -up dontpanic-1.00/configure.ac.fix_obsolete_m4s dontpanic-1.00/configure.ac --- dontpanic-1.00/configure.ac.fix_obsolete_m4s 2016-06-22 21:31:58.000000000 +0200 +++ dontpanic-1.00/configure.ac 2017-09-04 12:35:55.066064941 +0200 @@ -11,8 +11,7 @@ AC_CONFIG_FILES([src/dontpanic.pc]) # Checks for programs. AC_PROG_CC -AC_PROG_LIBTOOL -AM_PROG_LIBTOOL +LT_INIT # Checks for libraries. - You can replace %setup -q + patchX -p1 with the following macro that will handle the setup and all the patches automatically: %prep %autosetup -p1 - There's a typo in your comment above your patch: congifured → configured The good news is I don't get installation errors anymore.
(In reply to Robert-André Mauchin from comment #5) > AutoTools: Obsoleted m4s found > ------------------------------ > AM_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:15 > AC_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:14 > > > These need to be patched with LT_INIT. See > https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html for > further details. > > Here's a patch: > > diff -up dontpanic-1.00/configure.ac.fix_obsolete_m4s > dontpanic-1.00/configure.ac > --- dontpanic-1.00/configure.ac.fix_obsolete_m4s 2016-06-22 > 21:31:58.000000000 +0200 > +++ dontpanic-1.00/configure.ac 2017-09-04 12:35:55.066064941 +0200 > @@ -11,8 +11,7 @@ AC_CONFIG_FILES([src/dontpanic.pc]) > > # Checks for programs. > AC_PROG_CC > -AC_PROG_LIBTOOL > -AM_PROG_LIBTOOL > +LT_INIT > > # Checks for libraries. > The configure.ac already calls LT_INIT. These deprecated macros are there for backward compatibility. There is no need to remove them now. > - You can replace %setup -q + patchX -p1 with the following macro that will > handle the setup and all the patches automatically: > > %prep > %autosetup -p1 > That would add build-time dependency on git. I won't do it. > - There's a typo in your comment above your patch: congifured → configured > The typo is fixed in the updated package that is located on the same addresses.
All right, package accepted.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dontpanic
Thank you for the review and the repository.