Bug 1488214 (deepin-manual) - Review Request: deepin-manual - Deepin User Manual
Summary: Review Request: deepin-manual - Deepin User Manual
Keywords:
Status: CLOSED CANTFIX
Alias: deepin-manual
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview
TreeView+ depends on / blocked
 
Reported: 2017-09-04 17:30 UTC by sensor.wen
Modified: 2018-09-04 18:27 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-21 15:21:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2017-09-04 18:44:43 UTC
Hello,

  - One issue with the icon you install, you need to run gtk-update-icon-cache:

%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

    and you need to Require hicolor-icon-theme:

Requires:       hicolor-icon-theme


  - Internet access is disabled during Koji and Mock builds, thus you can't download all the node modules required for the manual. You need to either to bundle them. Or better: you could package them all with node2rpm, and their dependencies… it would be a lot of work though.

List of dependencies:

  "dependencies": {
    "angular": "^1.3.15",
    "angular-animate": "^1.3.15",
    "angular-gettext": "^2.0.5",
    "angular-hotkeys": "^1.4.5",
    "babel-core": "^5.1.11",
    "babelify": "^5.0.4",
    "browserify": "^9.0.4",
    "expect.js": "^0.3.1",
    "gulp": "^3.8.11",
    "gulp-angular-gettext": "^2.1.0",
    "gulp-mocha": "^2.0.1",
    "gulp-ng-annotate": "^0.5.2",
    "gulp-rename": "^1.2.2",
    "gulp-uglify": "^1.2.0",
    "jquery": "^2.1.3",
    "marked": "^0.3.3",
    "mousetrap": "^1.5.2",
    "url-parse": "^1.0.0"
  },
  "devDependencies": {
    "gulp-sass": "^1.3.3",
    "gulp-sourcemaps": "^1.5.2"
  }

Comment 2 Robert-André Mauchin 🐧 2018-01-20 16:51:32 UTC
Not needed anymore:
  - One issue with the icon you install, you need to run gtk-update-icon-cache:

Version 2 has been published, it seems the build system has changed (now cmake) .

Comment 3 Robert-André Mauchin 🐧 2018-01-22 20:16:05 UTC
I think the best course of action is to bundle the required node packages as a Source1, they are only needed at build time. Here's how I generated a node_modules.tar.gz:

# git clone https://github.com/linuxdeepin/deepin-manual
# cd deepin-manual
# git checkout %%version
# pushd src/web/
# npm install
# popd
# tar -czvf node_modules.tar.gz src/web/node_modules
Source1:        node_modules.tar.gz



Also version 2 now depends on qcef: https://github.com/linuxdeepin/qcef
In order to speed things up, I have prepared a SPEC for you, you just need to review it and submit it as your own if you're ok with it. It is available here: https://eclipseo.fedorapeople.org/deepin/

Comment 4 Zamir SUN 2018-01-24 14:38:11 UTC
(In reply to Robert-André Mauchin from comment #3)
> Also version 2 now depends on qcef: https://github.com/linuxdeepin/qcef
> In order to speed things up, I have prepared a SPEC for you, you just need
> to review it and submit it as your own if you're ok with it. It is available
> here: https://eclipseo.fedorapeople.org/deepin/

Thanks.

I just talked with Felix (Fedora packager and also member of the Deepin Desktop developer), he mentioned that qcef is again bundled. We will need to look into qcef de-bundling first.

Comment 5 Robert-André Mauchin 🐧 2018-01-24 16:01:17 UTC
Qcef is bundling a precompiled cef, only for x86_64, that's not really Fedora compliant. It would be best to unbundle it. Otherwise deepin-manual would only be available on x86_64 on the programs depending on it too.

Comment 6 Zamir SUN 2018-06-21 15:21:53 UTC
Deepin take some of the files into their internal repo. So qcef is no longer compilable outside of their company. As a result, deepin-manual is not able to be packaged in Fedora. I am closing this request on behalf of the Deepin DE packaging effort.

https://github.com/linuxdeepin/qcef/issues/3


Note You need to log in before you can comment on or make changes to this bug.