Bug 1488242 - Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library
Summary: Review Request: mingw-python-setuptools - MinGW Windows Python setuptools lib...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1488240 1488245
TreeView+ depends on / blocked
 
Reported: 2017-09-04 19:20 UTC by Sandro Mani
Modified: 2017-09-07 15:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-07 15:33:24 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Sandro Mani 2017-09-04 19:20:28 UTC
Spec URL: https://smani.fedorapeople.org/review/mingw-python-setuptools.spec
SRPM URL: https://smani.fedorapeople.org/review/mingw-python-setuptools-36.2.0-1.fc28.src.rpm
Description: MinGW Windows Python setuptools library
Fedora Account System Username: smani

Comment 1 Robert-André Mauchin 🐧 2017-09-05 07:19:07 UTC
Hello, 

You're shipping *.exe, I think these should be removed like in the original package: https://apps.fedoraproject.org/packages/python-setuptools/sources/

%prep
# Remove bundled exes
rm -f setuptools/*.exe

   And:

%install
find %{mingw32_python2_sitearch}/ -name '*.exe' | xargs rm -f
find %{mingw64_python2_sitearch}/ -name '*.exe' | xargs rm -f


You also need to remove shebang from Python libraries otherwise rpmlint complains about non executables scripts:

%prep
# Strip shbang
find setuptools -name \*.py | xargs sed -i -e '1 {/^#!\//d}'

Comment 2 Sandro Mani 2017-09-05 08:23:39 UTC
I'm not sure about the reationale for removing the exes underneath site-packages, the native spec-file does not really explain it. But I've so far never had a use for them, so I'm ok with deleting them.

Spec URL: https://smani.fedorapeople.org/review/mingw-python-setuptools.spec
SRPM URL: https://smani.fedorapeople.org/review/mingw-python-setuptools-36.2.0-2.fc28.src.rpm

%changelog
* Tue Sep 05 2017 Sandro Mani <manisandro> - 36.2.0-2
- Remove bundled exes
- Remove shebangs on python modules
- Delete exes underneath site-packages

Comment 3 Robert-André Mauchin 🐧 2017-09-05 08:51:54 UTC
All good, package accepted.

Comment 4 Gwyn Ciesla 2017-09-05 12:35:42 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-setuptools


Note You need to log in before you can comment on or make changes to this bug.