Bug 1488466 – [RFE] Improve taskcleaner & unlock_entity execution

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1488466 - [RFE] Improve taskcleaner & unlock_entity execution

Summary:	[RFE] Improve taskcleaner & unlock_entity execution

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	ovirt-engine
Classification:	oVirt
Component:	Tools.Extensions (Show other bugs)
Sub Component:
Version:	4.2.0
Hardware:	Unspecified Unspecified

Priority	low Severity high (vote)
Target Milestone:	ovirt-4.2.0
Target Release:	4.2.0
Assigned To:	Miroslava Voglova
QA Contact:	Gonza
Docs Contact:

URL:
Whiteboard:
Keywords:	FutureFeature

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-09-05 08:53 EDT by Yaniv Kaul
Modified:	2017-12-20 06:46 EST (History)
CC List:	5 users (show)

See Also:
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	The taskcleaner and unlock_entity execution scripts have both had options for user, database, port and server names removed (-u, -d, -p, -s). Also there is no more need to export PGPASSWORD. All values are now obtained from the Manager configuration files.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-12-20 06:46:55 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Infra
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	mperina: ovirt‑4.2? grafuls: testing_plan_complete- rule-engine: planning_ack? mperina: devel_ack+ rule-engine: testing_ack+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	82511	master	MERGED	dbutils: improved execution of taskcleaner	2017-10-13 10:21 EDT
oVirt gerrit	82800	ovirt-engine-4.1	MERGED	packaging: bin: Source engine-prolog.sh directly	2017-10-16 07:28 EDT

Groups: None (edit)

Description Yaniv Kaul 2017-09-05 08:53:15 EDT

Description of problem:
This is the current way to execute the task cleaner:
# source /etc/ovirt-engine/engine.conf.d/10-setup-database.conf
# export PGPASSWORD=$ENGINE_DB_PASSWORD
# cd /usr/share/ovirt-engine/setup/dbutils
# ./taskcleaner.sh -A -J -z -R -u engine -d engine


I'm sure the task cleaner could easily get the password from /etc/ovirt-engine/engine.conf.d/10-setup-database.conf and save at least 2 lines of copy-paste, which may cause errors.

Comment 2 Gonza 2017-11-22 03:06:12 EST

Verified with:
ovirt-engine-4.2.0-0.0.master.20171119135709.git6d448d3.el7.centos.noarch

Comment 3 Red Hat Bugzilla Rules Engine 2017-11-22 03:06:17 EST

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 4 Sandro Bonazzola 2017-12-20 06:46:55 EST

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Note You need to log in before you can comment on or make changes to this bug.