Description of problem: novajoin-tempest-plugin is being added upstream. I've added a preliminary spec here: https://vakwetu.fedorapeople.org/python-novajoin-tests-tempest.spec
Initial licensecheck output: $ licensecheck -r . ./HACKING.rst: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache (v2.0) ./README.rst: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache ./setup.py: Apache (v2.0) GENERATED FILE ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./novajoin_tempest_plugin/README.rst: *No copyright* UNKNOWN ./novajoin_tempest_plugin/__init__.py: *No copyright* Apache (v2.0) ./novajoin_tempest_plugin/clients.py: Apache (v2.0) ./novajoin_tempest_plugin/config.py: Apache (v2.0) ./novajoin_tempest_plugin/plugin.py: Apache (v2.0) ./novajoin_tempest_plugin/ipa/ipa_client.py: Apache (v2.0) ./novajoin_tempest_plugin/tests/base.py: Apache (v2.0) ./novajoin_tempest_plugin/tests/test_novajoin_tempest_plugin.py: *No copyright* Apache (v2.0) ./novajoin_tempest_plugin/tests/scenario/manager.py: Apache (v2.0) ./novajoin_tempest_plugin/tests/scenario/novajoin_manager.py: Apache (v2.0) GENERATED FILE ./novajoin_tempest_plugin/tests/scenario/test_novajoin_enrollment.py: Apache (v2.0) ./novajoin_tempest_plugin/tests/scenario/test_tripleo_deployment.py: Apache (v2.0) ./novajoin_tempest_plugin/tests/scenario/test_tripleo_tls.py: Apache (v2.0) The package is licensed using the Apache 2.0 license.
Hello Ade, Thanks for submitting the package review. novajoin-tempest-plugin dist-git created: https://github.com/rdo-packages/novajoin-tempest-plugin-distgit Please send the RDO gerrit review for initial package import. Thanks, Chandan Kumar
Initial package import review: https://review.rdoproject.org/r/#/c/9310/ Haven't figured out yet why its failing.
Initial package import passing now.
Initial SRPM for Fedora review https://logs.rdoproject.org/10/9310/6/check/DLRN-rpmbuild/Z2cacc9dbb00347f19cb7db982df886fd/centos/current/python-novajoin-tests-tempest-0.0.1-0.20170925155923.59d7ba6.el7.centos.src.rpm generated by DLRN from initial import of spec file.
Here is the final package review: The fedora-review look good. rpmlint error: python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib can be fixed in a new patchset. The package is APPROVED now. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 2 files have unknown license. Detailed output of licensecheck in /home/vagrant/rdo_packaging/package_review/python-novajoin-tests- tempest/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -novajoin-tests-tempest , python-novajoin-tests-tempest-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.0.1.dev32 [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-novajoin-tests-tempest-0.0.1-0.20170925155923.59d7ba6.el7.centos.noarch.rpm python-novajoin-tests-tempest-doc-0.0.1-0.20170925155923.59d7ba6.el7.centos.noarch.rpm python-novajoin-tests-tempest-0.0.1-0.20170925155923.59d7ba6.el7.centos.src.rpm python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib python2-novajoin-tests-tempest.noarch: E: no-changelogname-tag python2-novajoin-tests-tempest.noarch: W: no-documentation python-novajoin-tests-tempest-doc.noarch: W: summary-not-capitalized C python-novajoin-tests-tempest documentation python-novajoin-tests-tempest-doc.noarch: E: no-changelogname-tag python-novajoin-tests-tempest.src: E: no-changelogname-tag python-novajoin-tests-tempest.src: W: invalid-url Source0: novajoin_tempest_plugin-0.0.1.dev32-0.20170925155923.59d7ba6.tar.gz 3 packages and 0 specfiles checked; 4 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib python2-novajoin-tests-tempest.noarch: E: no-changelogname-tag python2-novajoin-tests-tempest.noarch: W: no-documentation python-novajoin-tests-tempest-doc.noarch: W: summary-not-capitalized C python-novajoin-tests-tempest documentation python-novajoin-tests-tempest-doc.noarch: E: no-changelogname-tag 2 packages and 0 specfiles checked; 3 errors, 2 warnings. Requires -------- python2-novajoin-tests-tempest (rpmlib, GLIBC filtered): python(abi) python-gssapi python-oslo-config python-oslo-log python-pbr python-tempest python2-ipalib python2-six python-novajoin-tests-tempest-doc (rpmlib, GLIBC filtered): Provides -------- python2-novajoin-tests-tempest: python-novajoin-tests-tempest python2-novajoin-tests-tempest python-novajoin-tests-tempest-doc: python-novajoin-tests-tempest-doc Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -m dlrn-1 -r -b 1488615 Buildroot used: dlrn-centos7-x86_64-1 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
The package is now available in RDO Trunk: https://trunk.rdoproject.org/centos7-master/59/d7/59d7ba68345a55cd7c6879b623177ebdc39b0414_2f592237/rpmbuild.log Distgit at https://github.com/rdo-packages/novajoin-tempest-plugin-distgit