Bug 1490258 - fluentd produces warnings for each line processed for engine.log
Summary: fluentd produces warnings for each line processed for engine.log
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.0.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.1.8
: ---
Assignee: Shirly Radco
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks: 1475135 1513703
TreeView+ depends on / blocked
 
Reported: 2017-09-11 07:40 UTC by Roy Golan
Modified: 2017-12-11 16:31 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-metrics-1.0.8
Clone Of:
Environment:
Last Closed: 2017-12-11 16:31:42 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
fluent event file from OST (3.29 MB, text/plain)
2017-09-11 07:40 UTC, Roy Golan
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 83709 0 master MERGED fluentd:fix bug in engine.log parsing 2017-11-07 20:26:09 UTC
oVirt gerrit 83730 0 ovirt-engine-metrics-4.1 MERGED fluentd:fix bug in engine.log parsing 2017-11-07 20:58:41 UTC

Description Roy Golan 2017-09-11 07:40:23 UTC
Created attachment 1324364 [details]
fluent event file from OST

Description of problem:

Fluentd should process the engine log and forward them as events, but atm every line produces a warning.


Actual results:
2017-09-08T12:10:08-04:00       fluent.warn     {"message":"got incomplete line before first line from /var/log/ovirt-engine/engine.log: \"2017-09-08 12:10:08,841-04 DEBUG [org.ovirt.engine.core.vdsbroker.vdsbroker.GetAllVmStatsVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-20) [] START, GetAllVmStatsVDSCommand(HostName = lago-basic-suite-master-host-0, VdsIdVDSCommandParametersBase:{hostId='30fba1ba-62eb-4f60-ac27-871c6a0b785d'}), log id: 31ac440c\\n\""}


Expected results:
A normal event with the log record, for every log level, and exception as well

Additional info:
Engine.log was in debug mode.

Comment 1 Roy Golan 2017-09-11 07:43:08 UTC
I've checked ovirt's engine log layout and I don't see something special. Simply a line break (\n essentially) at the end of each message, nothing more.

Comment 2 Roy Golan 2017-09-11 11:33:41 UTC
An example of INFO message of the engine 

2017-09-08T12:10:34-04:00	fluent.warn	{"message":"got incomplete line before first line from /var/log/ovirt-engine/engine.log: \"2017-09-08 12:10:34,810-04 INFO  [org.ovirt.engine.core.uutils.config.ShellLikeConfd] (ServerService Thread Pool -- 44) [] The file '/etc/ovirt-engine/engine.conf' doesn't exist or isn't readable. Will return an empty set of properties.\\n\""}

Comment 4 Shirly Radco 2017-10-03 09:11:17 UTC
I checked this and the problem seems to be in the line before the log meddage that is stated in the fluentd.warn.

I would like to see the actual engine.log as well as the /var/log/messages so I can see the issue in the engine.log that causes it. Can you please attach fresh /var/log/messages and engine.log?

Comment 5 Shirly Radco 2017-10-03 09:12:45 UTC
or fluent event file, since I see you previously attached it.

Comment 10 Shirly Radco 2017-11-07 21:17:20 UTC
OST is set to utc-3 timezone.
The bug was that the regex expression only accepted 'utc+' and not 'utc-'.

Comment 11 Lukas Svaty 2017-11-28 16:14:26 UTC
verified in ovirt-engine-metrics-1.0.8-1.el7ev.noarch


Note You need to log in before you can comment on or make changes to this bug.