Spec URL: https://mizdebsk.fedorapeople.org/review/plexus-languages/plexus-languages.spec SRPM URL: https://mizdebsk.fedorapeople.org/review/plexus-languages/plexus-languages-0.9.3-1.fc28.src.rpm Description: Plexus Languages is a set of Plexus components that maintain shared language features. Fedora Account System Username: mizdebsk
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software - I know they're used only for tests, but guidelines are guidelines :/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 13 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1490338-plexus-languages/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in plexus- languages-javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: plexus-languages-0.9.3-1.fc28.noarch.rpm plexus-languages-javadoc-0.9.3-1.fc28.noarch.rpm plexus-languages-0.9.3-1.fc28.src.rpm plexus-languages.noarch: W: no-documentation plexus-languages.src:37: W: macro-in-comment %pom_remove_plugin 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory plexus-languages.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- plexus-languages (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.thoughtworks.qdox:qdox) mvn(org.ow2.asm:asm) plexus-languages-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- plexus-languages: mvn(org.codehaus.plexus:plexus-java) mvn(org.codehaus.plexus:plexus-java:pom:) mvn(org.codehaus.plexus:plexus-languages:pom:) plexus-languages plexus-languages-javadoc: plexus-languages-javadoc Source checksums ---------------- https://github.com/codehaus-plexus/plexus-languages/archive/plexus-languages-0.9.3.tar.gz : CHECKSUM(SHA256) this package : 81627cb6fcab581b5577a7e9116ad923d96f1694f83d4490495d642ab21688d4 CHECKSUM(SHA256) upstream package : 81627cb6fcab581b5577a7e9116ad923d96f1694f83d4490495d642ab21688d4 http://www.apache.org/licenses/LICENSE-2.0.txt : CHECKSUM(SHA256) this package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 Jar and class files in source ----------------------------- ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/dir.descriptor/out/module-info.class ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/mock/module-info.class ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/jar.manifest.with/plexus-java-1.0.0-SNAPSHOT.jar ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/jar.empty/plexus-java-1.0.0-SNAPSHOT.jar ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/jar.descriptor/asm-6.0_BETA.jar ./plexus-languages-plexus-languages-0.9.3/plexus-java/src/test/resources/jar.unsupported/jdom-1.0.jar Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1490338 Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Updated package: %changelog * Tue Sep 12 2017 Mikolaj Izdebski <mizdebsk> - 0.9.3-2 - Replace JARs used as test resources with symlinks to system JARs Spec URL: https://mizdebsk.fedorapeople.org/review/plexus-languages/plexus-languages.spec SRPM URL: https://mizdebsk.fedorapeople.org/review/plexus-languages/plexus-languages-0.9.3-2.fc28.src.rpm
APPROVED It would be worth adding something like: find -type f -name '*.jar' -exec sh -c 'jar tf {} | grep -q class' \; -delete to ensure that upstream doesn't bundle more JARs in the future.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plexus-languages
Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21819468