Bug 1490918 - Setting custom ip while adding Floating IP has no effect
Summary: Setting custom ip while adding Floating IP has no effect
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.8.0
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: GA
: 5.10.0
Assignee: Sam Lucidi
QA Contact: Omri Hochman
URL:
Whiteboard:
Depends On:
Blocks: 1513625
TreeView+ depends on / blocked
 
Reported: 2017-09-12 13:29 UTC by Patrik Holop
Modified: 2018-06-21 21:13 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1513625 (view as bug list)
Environment:
Last Closed: 2018-06-21 21:09:35 UTC
Category: Bug
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Patrik Holop 2017-09-12 13:29:34 UTC
Description of problem:
Setting optional floating IP address while adding new Floating IP address has no effect and created IP address has IP, that was automatically given to it.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Navigate to Networks -> Floating IPs
2. Choose Configuration -> Add a new Floating IP
3. While setting information type custom "Floating IP address"
4. Add new floating IP
5. Wait for new IP to be created (Networks -> Floating IPs)

Actual results:
New IP is created with automatically chosen IP address

Expected results:
New IP address should to the one you typed in form while adding new IP.

Additional info:
Tested on OpenStack cloud provider

Comment 3 Sam Lucidi 2017-10-09 19:45:08 UTC
Didn't realize this was already assigned. I've put together PRs to fix this:

https://github.com/ManageIQ/manageiq-ui-classic/pull/2312 (already merged)
https://github.com/ManageIQ/manageiq-providers-openstack/pull/109

Comment 5 Patrik Holop 2017-11-07 08:51:10 UTC
I retested it on version 5.9.0.5 -> rhos7.
When I dont type IP address, error is displayed, that ip is not valid even though its described on view as optional.
When I wrote IP address 10.8.58.175, no address was added. 
Can you double check it?

Comment 6 Sam Lucidi 2017-11-07 19:07:52 UTC
A fix for the field not being treated as optional is available here: https://github.com/ManageIQ/manageiq-providers-openstack/pull/145

Are you sure that no floating IP address is being created in the other case? You may need to wait for the inventory to be refreshed for it to be visible in ManageIQ.

Comment 7 Patrik Holop 2017-11-10 09:19:37 UTC
Maybe it was a long delay, after retesting it worked correctly. Can you take a look on the case, where you dont type any ip (optional) a it gives you error    
"" is not valid IP? Or should it be a new bugzilla?

Comment 8 Sam Lucidi 2017-11-10 13:59:40 UTC
Maybe I'm not understanding, but the pull request in comment 6 should fix the problem when the ip is left blank.

Comment 9 Patrik Holop 2017-11-13 07:19:53 UTC
Sorry, I haven't noticed the link before. I will change the state of bugzilla back to post and wait until it's merged.


Note You need to log in before you can comment on or make changes to this bug.