Spec URL: https://gitlab.com/osas/osas-infra-team-rpm-pkg/blob/master/needrestart/needrestart.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/duck/osas-infra-team-rpm-repo/epel-7-x86_64/00601454-needrestart/needrestart-2.11-1.src.rpm Description: needrestart checks which daemons need to be restarted after library upgrades. It is inspired by checkrestart from the debian-goodies package. Fedora Account System Username: duck Quack, This package is not present in the distribution and no other ticket was found. The package builds well and works well too. There are two workarounds which are explained in the spec file. I also created YUM and DNF plugins to integrate after a successful transaction, as is done with APT in Debian. Once others have tested it well, then I plan to suggest it upstream. Debconf being already packaged and working well I activated the corresponding feature. It is always possible to use the basic terminal UI if anyone wishes too (and this can be set globally in the config file). I already proposed a package (postsrsd) for review and it was accepted, so this is my second contribution. I'm also looking for a sponsor. Regards. \_o<
When you install needrestart, it's a commitment for *life*. Any attempt would result in a crash. Joking :-). So I fixed the YUM and DNF plugins to detect the situation and handle it gracefully. Btw, I'm still in need of a reviewer and a sponsor. o-negai itashimasu!
I fixed a few thing in -3 version. Could someone have a look please?
Adding a reference to raw files in order to make fedora-review work directly. SPEC: https://gitlab.com/osas/osas-infra-team-rpm-pkg/raw/master/needrestart/needrestart.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/duck/osas-infra-team-rpm-repo/epel-7-x86_64/00601454-needrestart/needrestart-2.11-1.src.rpm
Please make sure, spec in -3 and the srpm are actually the same version. Then: needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/10-dpkg needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/20-rpm needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/30-pacman needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/90-none needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/200-write needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/400-notify-send needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/600-mail needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/auditd.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/dbus.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/systemd-manager needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/sysv-init Please remove the executable flags from those files. - in order to prevent unowned directories, you'll need to add a dependency to yum itself, see rpm -qf /etc/yum/pluginconf.d - please also add an empty line between changelog entries in order to enhance readability.
Thanks for taking time to review. Yes I do rebuild with the final release number. I'm tagging releases and I plan to split the repository to get on building on push while this one would build on tags only. It's not just done yet. Which tool do you use to get this lint-ing? I tried rpmlint but it was not really helpful, suggesting changes incompatible with the Fedora guidelines. How is the dependency on yum helping? Is there some code in YUM changing behavior because of it? Because if I need to remove YUM, if we suppose someone would like to use some alternative instead, it end-up with: Error: Trying to remove "yum", which is protected So I don't see how YUM could me missing. Same for DNF I guess. As for executable files, The 'README.needrestart' files in /etc/needrestart/restart.d/ and /etc/needrestart/notify.d/ explicitly say the files will only be considered if they are executables. There's nothing said for /etc/needrestart/hook.d/ but I guess this is the same logic. \_o<
-4 has the changelog updated. Waiting for answers for the rest.
I'm using a tool named fedora-review. Calling it fedora-review -b 1491017 (-b is bug number) it will parse this page here for the last "SPEC:" and the last "SRPM:" line as in https://bugzilla.redhat.com/show_bug.cgi?id=1491017#c3 , pull down the files linked by that URL and will run a set of tests on that, like building the package, and running rpmlint on built packages, will simulate to install the package etc. yum provides the directory /etc/yum/pluginconf.d (and a set of files). You should not place a file in a directory, which is currently unowned. In theory, all system provided directories and files are being kept in rpm inventory (or the other way around, everything else is user content). RPM also "knows" a checksum of those files and can check, if a file was changed. You can not remove yum (and dnf, and a set of other packages), because it's protected. For the executable flags in /etc/needrestart, please add your explanation from above to the %files section as a comment. That should be enough. As first step in order to test your submission, you probably want to add a new spec and srpm line to the bz ticket.
Ok, in my first review, I've missed a missing dependency to python3-dnf, because of copying content to /usr/lib/python3.6/site-packages/dnf-plugins/ (owned by python3-dnf)
SPEC: https://gitlab.com/osas/osas-infra-team-rpm-pkg/raw/needrestart-2.11-5/needrestart/needrestart.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/duck/osas-infra-team-rpm-repo/epel-7-x86_64/00608855-needrestart/needrestart-2.11-5.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2)", "GPL (v2 or later)", "Unknown or generated". 35 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1491017-needrestart/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/polkit-1/actions(polkit, systemd), /usr/lib/python3.6/site- packages/dnf-plugins(python3-dnf), /usr/lib/python3.6/site-packages (system-python-libs), /usr/share/polkit-1(polkit, systemd), /usr/lib/python3.6/site-packages/dnf-plugins/__pycache__(python3-dnf) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: needrestart-2.11-5.noarch.rpm needrestart-2.11-5.src.rpm needrestart.noarch: W: spelling-error %description -l en_US checkrestart -> check restart, check-restart, checkerboard needrestart.noarch: W: spelling-error %description -l en_US debian -> Debian needrestart.noarch: E: description-line-too-long C needrestart checks which daemons need to be restarted after library upgrades. It is inspired by checkrestart from the debian-goodies package. needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/10-dpkg needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/20-rpm needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/30-pacman needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/90-none needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/200-write needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/400-notify-send needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/600-mail needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/auditd.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/dbus.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/systemd-manager needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/sysv-init needrestart.src: W: spelling-error %description -l en_US checkrestart -> check restart, check-restart, checkerboard needrestart.src: W: spelling-error %description -l en_US debian -> Debian needrestart.src: E: description-line-too-long C needrestart checks which daemons need to be restarted after library upgrades. It is inspired by checkrestart from the debian-goodies package. needrestart.src:70: E: hardcoded-library-path in %{buildroot}/usr/lib/yum-plugins needrestart.src:72: E: hardcoded-library-path in %{buildroot}/usr/lib/yum-plugins/needrestart.py needrestart.src:87: W: libdir-macro-in-noarch-package (main package) # %{_libdir} resolves to /usr/lib64 on 64-bits systems, but the software does not handle this needrestart.src:87: W: macro-in-comment %{_libdir} needrestart.src:88: E: hardcoded-library-path in /usr/lib/%{name} needrestart.src:97: E: hardcoded-library-path in /usr/lib/yum-plugins 2 packages and 0 specfiles checked; 17 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- needrestart.noarch: W: spelling-error %description -l en_US checkrestart -> check restart, check-restart, checkerboard needrestart.noarch: W: spelling-error %description -l en_US debian -> Debian needrestart.noarch: E: description-line-too-long C needrestart checks which daemons need to be restarted after library upgrades. It is inspired by checkrestart from the debian-goodies package. needrestart.noarch: W: invalid-url URL: https://github.com/liske/needrestart <urlopen error [Errno -2] Name or service not known> needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/10-dpkg needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/20-rpm needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/30-pacman needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/hook.d/90-none needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/200-write needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/400-notify-send needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/notify.d/600-mail needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/auditd.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/dbus.service needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/systemd-manager needrestart.noarch: E: executable-marked-as-config-file /etc/needrestart/restart.d/sysv-init 1 packages and 0 specfiles checked; 12 errors, 3 warnings. Requires -------- needrestart (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl config(needrestart) perl(Debconf::Client::ConfModule) perl(Locale::TextDomain) perl(Module::Find) perl(Module::ScanDeps) perl(Proc::ProcessTable) perl(Sort::Naturally) perl(Term::ReadKey) python(abi) python3-dnf xz Provides -------- needrestart: config(needrestart) needrestart Source checksums ---------------- https://github.com/liske/needrestart/archive/v2.11/needrestart-2.11.tar.gz : CHECKSUM(SHA256) this package : 5c7c322e551ae5de9442ac4915d6c9bc47303a22bc8fb234b953d4a158e65777 CHECKSUM(SHA256) upstream package : 5c7c322e551ae5de9442ac4915d6c9bc47303a22bc8fb234b953d4a158e65777 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1491017 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, Perl Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Package approved. One issue left is the description line is too long. You can break the line where it suits you, preferable somewhere <79 chars. That can be done during package import. I'll sponsor you into the packager group.
Taking care of the latest fixes. Thanks a lot :-).
$ fedrepo-req needrestart -t 1491017 Error: The Bugzilla bug is not approved yet Could you have a look please?
done, sorry for the inconvenience.
The tool is picky about the title format too. Request done, thanks :-).
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/needrestart