Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1491042 - In case keystone is using multiple ldap backend, sosreport should also get /etc/keystone/domains
In case keystone is using multiple ldap backend, sosreport should also get /e...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: sos (Show other bugs)
7.4
Unspecified Unspecified
low Severity low
: pre-dev-freeze
: 7.5
Assigned To: Pavel Moravec
Miroslav Hradílek
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-12 17:23 EDT by David Hill
Modified: 2018-04-10 14:05 EDT (History)
12 users (show)

See Also:
Fixed In Version: sos-3.5-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2018-04-10 14:04:13 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Github sosreport/sos/pull/1109 None None None 2017-09-23 15:18 EDT
Github sosreport/sos/pull/1147 None None None 2017-11-15 11:34 EST
Red Hat Product Errata RHEA-2018:0963 None None None 2018-04-10 14:05 EDT

  None (edit)
Description David Hill 2017-09-12 17:23:04 EDT
Description of problem:
In case keystone is using multiple ldap backend, sosreport should also get /etc/keystone/domains

Version-Release number of selected component (if applicable):


How reproducible:
Always ?

Steps to Reproduce:
1. sosreport of the title
2.
3.

Actual results:
/etc/keystone/domains is missing (or whatever string is configured in the keystone.conf file)

Expected results:


Additional info:
Comment 2 Pavel Moravec 2017-09-15 02:34:47 EDT
Do I get it right, that it is required from sos to:

- inspect content of keystone.conf (I expect /etc/keystone/keystone.conf)
- find a value of ??which-one?? property, if present
- collect that value of that property (should be /etc/keystone/domains)
- if not specified / not found, collect /etc/keystone/domains as a default

Am I right here? What is the property name, please? Can't be the value of that property obtained from a command (as a preffered way to sos grepping the property manualy and relying the syntax of the config file is stable over years)?
Comment 3 David Hill 2017-09-15 10:29:00 EDT
That looks correct and the values are the following:

[identity]
domain_specific_drivers_enabled = True
domain_config_dir = /etc/keystone/domains
Comment 4 Bryn M. Reeves 2017-09-15 10:34:32 EDT
What's the rationale for the path being configurable, and is a non-default path a supported configuration fro Red Hat products?

We can parse the configuration file if it is absolutely necessary but it seems curious to allow this path to be specified by the administrator.
Comment 5 Pavel Moravec 2017-09-23 10:48:33 EDT
It would be bit tricky to parse the config file that way, since we have to ensure that:

- [identity] is preceded the domain_config_dir
- no other section is between [identity] and domain_config_dir
- read that value

I am checking various keystone.conf in sosreports I have got access to - and so far the stats are:

- 773 sosreports with that config found
- 103 have that option uncommented
- none of them sets non-default value

So I think the parsing would be error-prone while providing very limited to none additional info/data.
Comment 6 David Hill 2017-09-23 10:51:29 EDT
I don't agree on this one.  It really helps to have that information as we actually are asking the customer to copy/paste that in the cases but if it was in sos_report, we could simply look at those configurations ...  But it's up to you here.
Comment 7 Pavel Moravec 2017-09-23 11:12:56 EDT
(In reply to David Hill from comment #6)
> I don't agree on this one.  It really helps to have that information as we
> actually are asking the customer to copy/paste that in the cases but if it
> was in sos_report, we could simply look at those configurations ...  But
> it's up to you here.

Is that alternate config location supported?

What support cases are you asking for that (to see if their config really points to non-default dir. location)
Comment 8 Pavel Moravec 2017-09-23 13:24:26 EDT
(I mean, we _will_ collect the content of /etc/keystone/domains but I am not convinced we should parse the config file to optionally collect non-default directory content)
Comment 9 David Hill 2017-09-23 14:08:54 EDT
Oh no... I'm not asking for that either but if 99% of the cases don't have the default location, we can always tell the customer to not change it .  That'd be great to have in sosreport.
Comment 10 Pavel Moravec 2017-11-03 09:34:35 EDT
POSTed to upstream and also MODIFIED due to rebase.
Comment 14 Pavel Moravec 2017-11-15 11:34:12 EST
Also https://github.com/sosreport/sos/pull/1147 needs to be present in 7.5 (if nothing else then to scrub LDAP passwords in the default domains dir that doesnt happen ATM).
Comment 20 errata-xmlrpc 2018-04-10 14:04:13 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0963

Note You need to log in before you can comment on or make changes to this bug.