Description of problem: Engine assigning MAC addresses which are in use by VMs when creating new VM from template. If creating new VM based on template, engine assigning MAC addresses which are already in use by some VMs in the destination cluster when are no duplicate is allowed! Version-Release number of selected component (if applicable): 4.2.0-0.0.master.20170912134930.gitc81ca84.el7.centos How reproducible: Seems to be 100% Steps to Reproduce: 1. Create few VMs with few vNICs on each - no duplicate allowed in cluster! 2. Create template from one of the VMs 3. Create new VM based on the template Actual results: Engine assigned some of the vNIC with MAC addresses that are in use by VMs in the cluster. Expected results: Engine should not assign MAC addresses which are in use and no duplicate is allowed in the cluster.
Created attachment 1325250 [details] engine log
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Also when creating a new VM (not from a template) add vNIC failed with MAC already in use.
Thanks for finding this, code relied on vm interfaces being set after VM being obtained from DB, which is not happening. In such case, extra DB call has to be made to fetch VM nics. I overlook that and unit tests did not reveal this, because read from DB is mocked. Sorry about that.
(In reply to Martin Mucha from comment #4) > Thanks for finding this, code relied on vm interfaces being set after VM > being obtained from DB, which is not happening. In such case, extra DB > call has to be made to fetch VM nics. I overlook that and unit tests did not > reveal this, because read from DB is mocked. Sorry about that. so to put it more clearly, this error means, that *no* macs are discovered and registered on startup, every used mac is thus considered as unused. Patch has already +2, so it will be merged very soon.
Verified on - 4.2.0-0.0.master.20170917124606.gita804ef7.el7.centos
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.