Bug 1491230 - add indication to snapshot in preview
Summary: add indication to snapshot in preview
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: bugs@ovirt.org
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-13 11:22 UTC by Lucie Leistnerova
Modified: 2017-12-20 11:00 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:00:43 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+


Attachments (Terms of Use)
snapshot subtab (47.85 KB, image/png)
2017-09-13 11:22 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 82123 0 master MERGED webadmin: fix Snapshots clone NPE and disk grid header 2017-09-24 12:35:08 UTC
oVirt gerrit 82124 0 master MERGED webadmin: update icons for Snapshot status indicator 2017-09-24 13:29:30 UTC

Description Lucie Leistnerova 2017-09-13 11:22:50 UTC
Created attachment 1325318 [details]
snapshot subtab

Description of problem:
When VM is in preview it is difficult to find the exact snapshot that it's previewing. In Snapshot subtab is 'Active VM before the preview' that indicates using snapshot, but without expanding all of the snapshots General sections (Status IN_PREVIEW) is not visible which of them it is.
In previous versions status In preview was visible and the description text changed color.

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170907100709.git14accac.el7.centos.noarch


How reproducible: always


Steps to Reproduce:
1. have VM, create snapshot
2. preview the snapshot


Actual results: nothing in snapshot header that indicates that snapshot is in preview, see attachment


Expected results: could be different icon before snapshot name

Comment 1 Michal Skrivanek 2017-09-14 05:16:13 UTC
Not sure whar was changed in this particular place. Alex?

Comment 2 Alexander Wels 2017-09-14 13:07:13 UTC
Well I completely rewrote the view, so it is highly possible I didn't include something that was there before. I guess the information is there, but some critical piece of information is hidden in an expansion. I guess you want some clear indication that snapshot is in preview? It should be fairly easy to change the icon from a camera to an eye or something if the snapshot is in preview.

Comment 3 Michal Skrivanek 2017-09-14 13:13:40 UTC
IIRC it used to be in bold (or was it saying additional "(in preview)"? not sure), but any differentiation is ok I guess. Whatever works for you as visually pleasing and patternfly compliant:)

Comment 4 Lucie Leistnerova 2017-09-14 13:18:18 UTC
(In reply to Alexander Wels from comment #2)
> Well I completely rewrote the view, so it is highly possible I didn't
> include something that was there before. I guess the information is there,
> but some critical piece of information is hidden in an expansion. I guess
> you want some clear indication that snapshot is in preview? It should be
> fairly easy to change the icon from a camera to an eye or something if the
> snapshot is in preview.

Eye instead of camera sounds really good.

Comment 5 Alexander Wels 2017-09-14 13:20:44 UTC
Well I can do it, but you will be near the bottom of a large pile of issues I am working on it. If you can get one of your guys to do it, it should be fairly straight forward switching the icon based on a field.

Comment 6 Michal Skrivanek 2017-09-14 13:30:42 UTC
same here, please keep it in your pile and lets' see who gets to it first. It's not really urgent, just need to be fixed eventually before GA

Comment 7 Red Hat Bugzilla Rules Engine 2017-09-14 13:31:10 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 8 Lucie Leistnerova 2017-10-16 08:42:00 UTC
Snapshot in preview has different icon.

verified in ovirt-engine-webadmin-portal-4.2.0-0.0.master.20171013142622.git15e767c.el7.centos.noarch

Comment 9 Sandro Bonazzola 2017-12-20 11:00:43 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.