Bug 1491307 - Samba smb.conf manpage generation fails with xsltproc hitting the maximum allowed recursion
Summary: Samba smb.conf manpage generation fails with xsltproc hitting the maximum all...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: docbook-style-xsl
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ondrej Vasik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-13 13:25 UTC by Andreas Schneider
Modified: 2017-10-06 10:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-06 10:20:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andreas Schneider 2017-09-13 13:25:30 UTC
Description of problem:

The smb.conf manpage generation of Samba fails with xsltproc hitting the maximum allowed recursion. It is a pretty huge manpage.

The error:

[3263/3377] Generating manpages/smb.conf.5
runtime error: file file:///usr/share/sgml/docbook/xsl-stylesheets-1.79.2/lib/lib.xsl line 54 element choose                                                              
xsltApplySequenceConstructor: A potential infinite template recursion was detected.  
You can adjust xsltMaxDepth (--maxdepth) in order to raise the maximum number of nested template calls and variables/params (currently set to 3000).                      
Templates:                                
#0 name string.subst                      
#1 name string.subst                      
#2 name string.subst                      
#3 name string.subst                      
#4 name string.subst                      
#5 name string.subst                      
#6 name string.subst                      
#7 name string.subst                      
#8 name string.subst                      
#9 name string.subst                      
#10 name string.subst                     
#11 name string.subst                     
#12 name string.subst                     
#13 name string.subst                     
#14 name string.subst


The fix:

https://anonscm.debian.org/cgit/collab-maint/docbook-xsl.git/tree/debian/patches/765567_non-recursive_string_subst.patch

I've confirmed that the smb.conf is generated without an error after applying that patch!

Could you please apply this fix to the package in Fedora?

Comment 1 Andreas Schneider 2017-09-13 13:28:40 UTC
Alexander created a pull request:

https://src.fedoraproject.org/rpms/docbook-style-xsl/pull-request/1

Comment 2 Ondrej Vasik 2017-09-13 14:12:21 UTC
Thanks for report and analysis. Do you know whether they already reported it upstream or not? I don't want to step into it as fix came from Debian, so they deserve the credit for fix...

Comment 3 Alexander Bokovoy 2017-09-28 14:11:37 UTC
No idea on whether it is reported upstream or not. It would be good to actually merge the fix to Rawhide, though. We are not able to build samba in Rawhide at all due to this issue.

Comment 4 Tomas Krizek 2017-10-06 08:31:39 UTC
Merging the above fix in rawhide would be great, since this also blocks FreeIPA builds in rawhide. Because krb5-1.16.0 was released, we need to rebuild both samba and freeipa.

Any ETA on applying the fix to rawhide?

Comment 5 Ondrej Vasik 2017-10-06 10:20:04 UTC
Ok, merged and fixed issue with the patch, built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.