Bug 1491682
| Summary: | [ceph-iscsi-config]: New tpg creation should be blocked | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Ceph Storage | Reporter: | Tejas <tchandra> |
| Component: | iSCSI | Assignee: | Jason Dillaman <jdillama> |
| Status: | CLOSED ERRATA | QA Contact: | Tejas <tchandra> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.0 | CC: | ceph-eng-bugs, ceph-qe-bugs, jdillama, kdreyer, mmurthy |
| Target Milestone: | rc | ||
| Target Release: | 3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-05 23:43:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
PR #23 submitted for review to change the way errors are handled by the daemon (as proposed in the initial comment) https://github.com/ceph/ceph-iscsi-config/pull/23 Issue is not seen in recent builds.
Tried with negative scenarios where targetcli and gwcli had different config and login to gwcli failed, then brought back the setup to working condition. Created new targets from gwcli and same thing is reflected in targetcli. No extra tpg is created.
/iscsi-target...-igw/gateways> ls
o- gateways .................................................................................................. [Up: 2/2, Portals: 2]
o- avenger ..................................................................................................... [10.70.39.2 (UP)]
o- banshee ..................................................................................................... [10.70.39.3 (UP)]
/iscsi-target...-igw/gateways>
/iscsi> ls
o- iscsi .............................................................................................................. [Targets: 1]
o- iqn.2003-01.com.redhat.iscsi-gw:ceph-igw ............................................................................ [TPGs: 2]
o- tpg1 ............................................................................................ [no-gen-acls, auth per-acl]
| o- acls ............................................................................................................ [ACLs: 0]
| o- luns ............................................................................................................ [LUNs: 2]
| | o- lun0 .............................................................................................. [user/rbd.test1 (ao)]
| | o- lun1 ............................................................................................ [user/rbd.test2 (ano1)]
| o- portals ...................................................................................................... [Portals: 1]
| o- 10.70.39.2:3260 .................................................................................................... [OK]
o- tpg2 ............................................................................................................. [disabled]
o- acls ............................................................................................................ [ACLs: 0]
o- luns ............................................................................................................ [LUNs: 2]
| o- lun0 ............................................................................................ [user/rbd.test1 (ano2)]
| o- lun1 .............................................................................................. [user/rbd.test2 (ao)]
o- portals ...................................................................................................... [Portals: 1]
o- 10.70.39.3:3260 .................................................................................................... [OK]
/iscsi>
Versions :
ceph-iscsi-cli-2.5-8.el7cp.noarch
ceph-iscsi-config-2.3-10.el7cp.noarch
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:3387 |
Description of problem: Seeing an issue where on my 2 GW setup, saw an additional TPG get created. Here's some more details: I am seeing a new TPG has got created on my GWs ( seeing 3 tpgs from targetcli), and the login is failing on this new tpg. Not sure how this happened. I tried something like this: 1. deleted an image from RBD not gwcli, which was a part of the config. 2. GW failed to start saying image is not present. 3. SO created an image with the same name again from rbd, and started the rdb-target-gw. [Paul]: sounds like the failure to load left the config partially defined to LIO...and the rerun added further TPGs which is why things got out of wack. We should be able to reuse the signal_stop function, and put in an excpetion handler - so if the daemon throws a 'wobbly' the LIO configuration is cleared up. @Jason, @Mike - let me know if you agree with this approach and I'll get it done tomorrow (I have a PR to do for the CLI fixes anyway) Version-Release number of selected component (if applicable): ceph-iscsi-cli-2.5-5.el7cp.noarch ceph-iscsi-config-2.3-5.el7cp.noarch