SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/cnc/linuxcnc.git/plain/linuxcnc.spec?id=02de4a21060ceb18f14db17000c9f15d6921ea0d SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/cnc/fedora-rawhide-x86_64/00575087-linuxcnc/linuxcnc-2.7.9-1.fc27.src.rpm Description: LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more. Note that with stock (non-realtime) kernel the package is unfit for controlling the hardware. It can be used for software simulation. IT IS EXTREMELY UNWISE TO RELY ON SOFTWARE ALONE FOR SAFETY! Any machinery capable of harming persons must have provisions for completely removing power from all motors, etc, before persons enter any danger area. All machinery must be designed to comply with local and national safety codes, and the authors of this software can not, and do not, take any responsibility for such compliance.
Hello, - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - There's a typo in Source0: ${name} should be %{name} - Also you can simplify your Source0: like this: Source0: https://github.com/LinuxCNC/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz - You should provide a -doc subpackage: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5621760 bytes in 966 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - You should provide a systemd service file instead of a init.d script. - There are too much rpmlint errors to list them here, I suggest you run rpmlint on your end and fix the errors. * For example there are plenty of incorrect-fsf-address files, you should patch them with the correct address. https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address * Remove shebang from Python file: https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries * A setuid-binary /usr/bin/rtapi_app root 4755
Thanks (In reply to Robert-André Mauchin from comment #1) > Hello, > > > - Group: is not used in Fedora. See: > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > > - There's a typo in Source0: ${name} should be %{name} > > - Also you can simplify your Source0: like this: > > Source0: > https://github.com/LinuxCNC/%{name}/archive/v%{version}/%{name}-%{version}. > tar.gz > > - You should provide a -doc subpackage: > > Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 5621760 bytes in 966 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Done. > - You should provide a systemd service file instead of a init.d script. This would be non-trivial. I instead move it to %doc, since it's not really useful with Fedora kernel. > - There are too much rpmlint errors to list them here, I suggest you run > rpmlint on your end and fix the errors. > > * For example there are plenty of incorrect-fsf-address files, you > should patch them with the correct address. > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address > * Remove shebang from Python file: > https://fedoraproject.org/wiki/ > Packaging_tricks#Remove_shebang_from_Python_libraries > * A setuid-binary /usr/bin/rtapi_app root 4755 I attempted to fix the most important ones, notably the ones you mention. The FSF address thing has been reported and fixed upstream: https://github.com/LinuxCNC/linuxcnc/pull/331 New package: SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/cnc/linuxcnc.git/plain/linuxcnc.spec?id=d58629efead63f0d7915cee94ece1833b0083eb6 SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/cnc/fedora-26-x86_64/00603081-linuxcnc/linuxcnc-2.7.9-2.fc26.src.rpm
It seems ok, package accepted.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/linuxcnc
This package was never imported, but the repo was created... Lubomir, do you want to push it to the repos, or should we properly retire the package?
I've received no response, so I've filed a request to releng to orphan the package: https://pagure.io/releng/issue/10203
Package orphaned, closing as DEADREVIEW