Created attachment 1326120 [details]
This zip file contains the screenshot files mentioned in the description of BZ
Description of problem:
While creating a service of type "AnsibleTower" you can leave the "Provider" field blank and still create a service. If you order such service, then it will fail with error "Error: undefined method `manager' for nil:NilClass"
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Create a service of type "Ansible Tower" as shown in Attachment "LeavingProviderEmptyAllowed.png"
2.Make sure you leave provider empty
3.If you go to "Catalog Items" and look at basic information, you will see "Ansible Tower Job Template" is empty as shown in the Attachment "CreateServiceWithoutTemplate.png"
If you ordered such service, it will fail as shown in the attachment "FailedAnsibleServiceSinceTowerNotSelected.png"
Do not allow service creation if the Tower does not exist and not selected in providers.
In 18.104.22.168 as well, I can create such service. I did not try ordering it.
New commit detected on ManageIQ/manageiq-ui-classic/master:
Author: Greg Piatigorski <firstname.lastname@example.org>
AuthorDate: Thu May 3 19:16:14 2018 -0400
Commit: Greg Piatigorski <email@example.com>
CommitDate: Thu May 3 19:16:14 2018 -0400
Fixes Ansible Tower Service Catalog new item creation
Checks for required Provider and Job Template selections in the drop downs
app/controllers/catalog_controller.rb | 21 +
1 file changed, 21 insertions(+)
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.