Bug 1491966 - AFR entry self heal removes a directory's .glusterfs symlink.
Summary: AFR entry self heal removes a directory's .glusterfs symlink.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: posix
Version: 3.10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On: 1477169
Blocks: 1479118
TreeView+ depends on / blocked
 
Reported: 2017-09-15 07:35 UTC by Ravishankar N
Modified: 2017-10-06 17:11 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.6
Clone Of: 1477169
Environment:
Last Closed: 2017-10-06 17:11:53 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2017-09-15 07:35:45 UTC
+++ This bug was initially created as a clone of Bug #1477169 +++

Description of problem:
$subject

How reproducible:
100%

Steps to Reproduce:
-Create 1x2 replica, fuse mount it
-mkdir fuse_mount/d1
-mkdir fuse_mount/d1/dir
-mkdir fuse_mount/d2
-kill one brick and rename the dir: `mv fuse_mount/d1/dir use_mount/d2`
-Bring all bricks up and trigger heal.

Actual results:
fuse_mount/d2/dir won't have any gfid symlink.

Additional info:
For replica 3 volume, the heal won't even complete, see the .t attached.

--- Additional comment from Worker Ant on 2017-08-01 08:06:07 EDT ---

REVIEW: https://review.gluster.org/17945 (posix: add sanity checks for removing the gfid symlink for directories) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-02 10:59:12 EDT ---

REVIEW: https://review.gluster.org/17945 (posix: add sanity checks for removing the gfid symlink for directories) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-04 11:54:05 EDT ---

COMMIT: https://review.gluster.org/17945 committed in master by Jeff Darcy (jeff.us) 
------
commit 42c057a6d1a03dd2825a278393acb15d52220c8d
Author: Ravishankar N <ravishankar>
Date:   Mon Jul 31 23:38:20 2017 +0530

    posix: add sanity checks for removing the gfid symlink for directories
    
    ...during mkdir and rmdir. Otherwise, during entry self-heal, the
    directory could be left out without a .glusterfs symlink causing fops like
    opendir, readdir to fail.  The only chance the missing symlink will be
    created is when a fresh lookup comes on it.
    
    Change-Id: I2e1cf1bce8962ea80187edd8f6d73e0a09cf9f8e
    BUG: 1477169
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17945
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 1 Worker Ant 2017-09-15 07:37:02 UTC
REVIEW: https://review.gluster.org/18299 (posix: add sanity checks for removing the gfid symlink for directories) posted (#1) for review on release-3.10 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-09-23 12:20:00 UTC
COMMIT: https://review.gluster.org/18299 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 4aa4bf3f14175c91d392032515b5c0f76359b3e9
Author: Ravishankar N <ravishankar>
Date:   Fri Sep 15 13:04:09 2017 +0530

    posix: add sanity checks for removing the gfid symlink for directories
    
    Backport of https://review.gluster.org/17945
    
    ...during mkdir and rmdir. Otherwise, during entry self-heal, the
    directory could be left out without a .glusterfs symlink causing fops like
    opendir, readdir to fail.  The only chance the missing symlink will be
    created is when a fresh lookup comes on it.
    
    Change-Id: I2e1cf1bce8962ea80187edd8f6d73e0a09cf9f8e
    BUG: 1491966
    Signed-off-by: Ravishankar N <ravishankar>

Comment 3 Shyamsundar 2017-10-06 17:11:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.6, please open a new bug report.

glusterfs-3.10.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-October/000084.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.