Bug 1492044 - CSD build: invisible but working minimize, maximize and close icons even if csd key is set to false
Summary: CSD build: invisible but working minimize, maximize and close icons even if c...
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox   
(Show other bugs)
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-15 10:35 UTC by Andreas Nilsson
Modified: 2017-09-18 20:18 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-09-18 20:18:05 UTC
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
screenshot (124.74 KB, image/png)
2017-09-15 10:35 UTC, Andreas Nilsson 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Description Andreas Nilsson 2017-09-15 10:35:33 UTC 
Created attachment 1326392 [details]
screenshot

When I have CSD turned off in the build, I still get the minimize, maximize and close buttons on the rigth side of the tab strip. These look like buttons on hover and works when pressed. No icons though. These also take up space from the tab strip.
Comment 1 Martin Stransky 2017-09-15 10:43:38 UTC 
Yes, I can see that - very interesting. Reproductible for me when CSD is off and Firefox is in normal (not maximized) state.
Comment 2 Martin Stransky 2017-09-15 14:28:14 UTC 
Just a note - there's a fix for that:

diff --git a/browser/themes/linux/browser.css b/browser/themes/linux/browser.css
index a9557254fef3..be4e589efcf7 100644
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -792,22 +792,37 @@ html|span.ac-emphasize-text-url {
   padding: 3px;
 }
 
+@media not all and (-moz-gtk-csd-available) {
+  #main-window > #titlebar {
+    /* We need to hide the titlebar explicitly on versions of GTK without CSD. */
+    display: none;
+  }
+}
+
Comment 3 Martin Stransky 2017-09-18 20:18:05 UTC 
Added to github repo:
https://github.com/stransky/gecko-dev/commit/8aa44473897a79abd85e8402571abc462611934f
Note You need to log in before you can comment on or make changes to this bug.