Spec URL: https://davidcl.fedorapeople.org/exercism/exercism.spec SRPM URL: https://davidcl.fedorapeople.org/exercism/exercism-2.4.1-1.fc26.src.rpm Description: Exercism provides a way to do the problems on https://exercism.io Fedora Account System Username: davidcl
Hello, - In the description, https://exercism.io should not be https but http: the site is not available in https. - I've got a build error: + go build -o out/exercism exercism/main.go go: GOPATH entry is relative; must be absolute path: "". For more details see: 'go help gopath' To solve this, I've modified your SPEC like this: %prep %setup -q -n %{repo}-%{version} %patch1 -p1 %build mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/cli export GOPATH=$(pwd)/_build:%{gopath} go build -o out/exercism exercism/main.go - Packaging -devel and -unit-test-devel are not needed for a Go binary, just keep the main package. Thus you should also remove the Provides: only needed if the package is used as a library.
(In reply to Robert-André Mauchin from comment #1) > - In the description, https://exercism.io should not be https but http: the > site is not available in https. Nice catch ! I added the s blindly. > - I've got a build error: > > + go build -o out/exercism exercism/main.go > go: GOPATH entry is relative; must be absolute path: "". > For more details see: 'go help gopath' > To solve this, I've modified your SPEC like this: > > %prep > %setup -q -n %{repo}-%{version} > %patch1 -p1 > > %build > mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} > ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/cli > export GOPATH=$(pwd)/_build:%{gopath} > go build -o out/exercism exercism/main.go After some investigation, I'm able to reproduce. The 'GOPATH' did not expand to anything on mock (and on your system). A trailing "" is then resolved as a relative path. FIXED > - Packaging -devel and -unit-test-devel are not needed for a Go binary, > just keep the main package. Thus you should also remove the Provides: only > needed if the package is used as a library. OK, I removed them then and cleaned all the spec.
You didn't remove: %if 0%{?with_devel} %files devel -f devel.file-list %license LICENSE %doc CHANGELOG.md RELEASE.md README.md %dir %{gopath}/src/%{provider}.%{provider_tld}/%{project} %endif %if 0%{?with_unit_test} && 0%{?with_devel} %files unit-test-devel -f unit-test-devel.file-list %license LICENSE %doc CHANGELOG.md RELEASE.md README.md %endif ??
(In reply to Robert-André Mauchin from comment #4) > You didn't remove: > > %if 0%{?with_devel} > %files devel -f devel.file-list > %license LICENSE > %doc CHANGELOG.md RELEASE.md README.md > %dir %{gopath}/src/%{provider}.%{provider_tld}/%{project} > %endif > > %if 0%{?with_unit_test} && 0%{?with_devel} > %files unit-test-devel -f unit-test-devel.file-list > %license LICENSE > %doc CHANGELOG.md RELEASE.md README.md > %endif > > > ?? Right that's a miss ! Updated at : Spec URL: https://davidcl.fedorapeople.org/exercism/exercism.spec SRPM URL: https://davidcl.fedorapeople.org/exercism/exercism-2.4.1-1.fc26.src.rpm Description: Exercism provides a way to do the problems on https://exercism.io Fedora Account System Username: davidcl
Ok for me, package accepted.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/exercism
build completed http://koji.fedoraproject.org/koji/buildinfo?buildID=974100
So I accidentally tried to package this again before seeing this review. Are you planning to build for 27 or 26? Also, I think half the description is a bit irrelevant. A Fedora user doesn't care too much that there are no "extra" language dependencies, because that's all handled by the package manager. I went with something like this: Exercism allows you to download and solve practice problems in over 30 different languages. Exercism takes place in two places: the discussions happen on the website, and you work on exercises locally. The Command Line Interface bridges the gap, allowing you to fetch exercises and submit solutions to the site.