Bug 1493083 - UX: iSCSI import storage domains has missing grid
Summary: UX: iSCSI import storage domains has missing grid
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: x86_64
OS: Unspecified
high
high
Target Milestone: ovirt-4.2.0
: ---
Assignee: Greg Sheremeta
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-19 10:54 UTC by Elad
Modified: 2019-04-28 13:10 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:55:05 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.2+
gklein: blocker+


Attachments (Terms of Use)
engine.log (204.51 KB, application/x-gzip)
2017-09-19 11:45 UTC, Elad
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 82116 0 master MERGED webadmin: add grid sizing to ListModelObjectCellTable 2017-09-25 14:30:39 UTC

Description Elad 2017-09-19 10:54:14 UTC
Description of problem:
After discovering and login to iSCSI targets while there are valid storage domains to import on the exposed LUNs, the list of the storage domains to import is returned empty.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170915203601.git96df02d.el7.centos.noarch
vdsm-4.20.3-47.git4801123.el7.centos.x86_64

How reproducible:
Always, reproduced both via REST and UI

Steps to Reproduce:
1. Create an iSCSI domain, put it in maintenance and destroy it or remove it with format=false
2. via UI: import storage domain -> discvoer and login to the targets where the domain that was destroyed in step 1 resides
Via REST: POST: api/hosts/host_id/unregisteredstoragedomainsdiscover


Actual results:
The storage domains to import list is returned empty.

Response:

<action>
 <status>complete</status>
 <storage_domains/>
</action>


Expected results:
Valid storage domains to import should be returned

Comment 1 Raz Tamir 2017-09-19 11:01:00 UTC
Raising severity as import storage domain is broken

Comment 2 Allon Mureinik 2017-09-19 11:18:21 UTC
Logs please?

Comment 3 Elad 2017-09-19 11:45:35 UTC
Created attachment 1327916 [details]
engine.log

2017-09-19 13:28:06,334+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetDeviceListVDSCommand] (default task-10) [893685bc-a2e8-4953-968e-5ab267040859] START, GetDeviceListVDSCommand(HostName = host_mixed_3, GetDeviceListVDSCommandParameters:{hostId='79cd6fc0-0b71-4f3a-a0e6-2964ccd74a8b', storageType='ISCSI', checkStatus='false', lunIds='null'}), log id: 630fbce7

Comment 4 Allon Mureinik 2017-09-19 12:09:32 UTC
I don't see any call to GetUnregisteredBlockStorageDomains in the log.

Maor, can you please take a look?

Comment 5 Sandro Bonazzola 2017-09-19 15:41:21 UTC
blocking oVirt 4.2.0 alpha on this

Comment 6 Allon Mureinik 2017-09-19 15:49:36 UTC
(In reply to Sandro Bonazzola from comment #5)
> blocking oVirt 4.2.0 alpha on this

This is definitely a VERSION blocker, but I don't think we should block ALPHA on this.
Alpha is mainly for greenfield usecases, where import domains won't come into play.

Comment 7 Yaniv Kaul 2017-09-19 16:07:23 UTC
(In reply to Allon Mureinik from comment #6)
> (In reply to Sandro Bonazzola from comment #5)
> > blocking oVirt 4.2.0 alpha on this
> 
> This is definitely a VERSION blocker, but I don't think we should block
> ALPHA on this.
> Alpha is mainly for greenfield usecases, where import domains won't come
> into play.

Agreed. Not to mention that nothing prevents us from respinnig.

Comment 8 Maor 2017-09-20 09:41:04 UTC
From the logs it seems that the regression is related to the GUI.
The backend do return the storage domains:

2017-09-19 11:48:29,343+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetStorageDomainInfoVDSCommand] (default task-29) [] FINISH, HSMGetStorageDomainInfoVDSCommand, return: <StorageDomainStatic:{name='newblock', id='02727abe-8544-486e-9fbe-b00143390ced'}, 00000001-0001-0001-0001-000000000311>, log id: 21210c75

Will take a look at the recent changes in the GUI

Comment 11 Maor 2017-09-24 11:42:46 UTC
(In reply to Maor from comment #8)
> From the logs it seems that the regression is related to the GUI.
> The backend do return the storage domains:
> 
> 2017-09-19 11:48:29,343+03 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.
> HSMGetStorageDomainInfoVDSCommand] (default task-29) [] FINISH,
> HSMGetStorageDomainInfoVDSCommand, return:
> <StorageDomainStatic:{name='newblock',
> id='02727abe-8544-486e-9fbe-b00143390ced'},
> 00000001-0001-0001-0001-000000000311>, log id: 21210c75
> 
> Will take a look at the recent changes in the GUI

It looks like the last time the import block domain dialog worked properly was before commit 0ae56b88a502e59d1508ffcbf2693a8a508cf291 (webadmin: Replace cell table with data grid)

Alexander, can you please take a look?

Comment 12 Lucie Leistnerova 2017-10-11 12:10:02 UTC
by importing already created iscsi storage it is available in import list (both UI and REST)

verified in ovirt-engine-webadmin-portal-4.2.0-0.0.master.20171009063348.gitf2b70a1.el7.centos.noarch

Comment 13 Sandro Bonazzola 2017-12-20 10:55:05 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.