Red Hat Bugzilla – Bug 1493431
Should use less image parameters to deploy peometheus if we want to use images from brew or ops repo
Last modified: 2017-11-28 17:12:03 EST
Description of problem: Prometheus images are pulled from docker.io if we don't set value for: openshift_prometheus_image_proxy, openshift_prometheus_image_prometheus openshift_prometheus_image_alertmanager, openshift_prometheus_image_alertbuffer If we want to deploy prometheus on openstack and aws/gce, in order to pull images from brew or ops repo, we have to set values for these parameters, it is a little complicated. For example, we have to set values as: openshift_prometheus_image_proxy=registry.ops.openshift.com/openshift3/oauth-proxy openshift_prometheus_image_prometheus=registry.ops.openshift.com/openshift3/prometheus openshift_prometheus_image_alertmanager=registry.ops.openshift.com/openshift3/prometheus-alertmanager openshift_prometheus_image_alertbuffer=registry.ops.openshift.com/openshift3/prometheus-alert-buffer I think we could add one parameter, such as openshift_prometheus_image_prefix, then pull images from the named repo. For openstack, openshift_prometheus_image_prefix=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/ For aws/gce, openshift_prometheus_image_prefix=registry.ops.openshift.com/openshift3/ Version-Release number of selected component (if applicable): # rpm -qa | grep openshift-ansible openshift-ansible-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-roles-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-docs-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-callback-plugins-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-filter-plugins-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-playbooks-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch openshift-ansible-lookup-plugins-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch How reproducible: Always Steps to Reproduce: 1. Deploy prometheus via ansible # cd /usr/share/ansible/openshift-ansible/ # ansible-playbook -vvv -i ${INVENTORY_FILE} playbooks/byo/openshift-cluster/openshift-prometheus.yml 2. 3. Actual results: Expected results: Additional info: #inventory file [OSEv3:children] masters etcd nfs [masters] ${MASTER_URL} openshift_public_hostname=${MASTER_URL} [etcd] ${ETCD} openshift_public_hostname=${ETCD} [nfs] ${NFS} openshift_public_hostname=${NFS} [OSEv3:vars] ansible_ssh_user=root ansible_ssh_private_key_file="~/libra.pem" deployment_type=openshift-enterprise openshift_docker_additional_registries=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888 # Prometheus openshift_prometheus_state=present openshift_prometheus_namespace=prometheus
Essentially this means make prometheus observe the norms around image prefixes
tag for Prometheus images is latest, I think we should use version for tag, such as v1.0, and the latest images maybe have problems, customers want to use stable images
Maybe we should add another one parameter, such as openshift_prometheus_image_version to use specific version images
Submitted PR: https://github.com/openshift/openshift-ansible/pull/5787
Set openshift_prometheus_image_prefix and openshift_prometheus_image_version in inventory file, it will pull prometheus, oauth-proxy, prometheus-alertmanager, prometheus-alert-buffer images now. env: # openshift version openshift v3.7.0-0.191.0 kubernetes v1.7.6+a08f5eeb62 etcd 3.2.8 # rpm -qa | grep openshift-ansible openshift-ansible-lookup-plugins-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-playbooks-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-filter-plugins-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-callback-plugins-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-roles-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-docs-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch openshift-ansible-3.7.0-0.191.0.git.0.bc2ff60.el7.noarch images: prometheus-alert-buffer/images/v3.7.0-0.194.0.0 prometheus-alertmanager/images/v3.7.0-0.194.0.0 oauth-proxy/images/v3.7.0-0.194.0.0 prometheus/images/v3.7.0-0.194.0.0
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:3188