Bug 1493457 - Review Request: rust-unicode-xid - Determine whether characters have XID_Start/XID_Continue properties according to Unicode Standard Annex #31
Summary: Review Request: rust-unicode-xid - Determine whether characters have XID_Star...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-20 09:07 UTC by Igor Gnatenko
Modified: 2017-10-17 15:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-17 15:31:30 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Gnatenko 2017-09-20 09:07:46 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-unicode-xid.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-unicode-xid-0.1.0-1.fc28.src.rpm
Description:
Determine whether characters have the XID_Start or XID_Continue
properties according to Unicode Standard Annex #31.
Fedora Account System Username: ignatenkobrain
Comment 1 Neal Gompa 2017-09-20 14:38:56 UTC 
Taking this review.
Comment 2 Neal Gompa 2017-09-20 15:08:37 UTC 
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

Two errors of concern:

rust-unicode-xid-devel.noarch: E: summary-too-long C Determine whether characters have XID_Start/XID_Continue properties according to Unicode Standard Annex #31

rust-unicode-xid-devel.noarch: E: wrong-script-interpreter /usr/share/cargo/registry/unicode-xid-0.1.0/scripts/unicode.py /usr/bin/env python

Address these and I'll be able to approve it.
Comment 3 Neal Gompa 2017-09-20 17:28:26 UTC 
The updated files look good.

PACKAGE APPROVED.
Comment 4 Gwyn Ciesla 2017-09-20 17:37:54 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicode-xid
Note You need to log in before you can comment on or make changes to this bug.