Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1493971

Summary: Repeat ovirt-engine-rename doesn't work for invalid hostname
Product: [oVirt] ovirt-engine Reporter: David Necpal <dnecpal>
Component: Tools.RenameAssignee: Yedidyah Bar David <didi>
Status: CLOSED DUPLICATE QA Contact: Pavel Stehlik <pstehlik>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-24 06:33:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Necpal 2017-09-21 09:00:25 UTC
Description of problem:
After using ovirt-engine-rename and change hostname, it is not possible to use ovirt-engine-rename again because of error: "Host name is not valid:...". 

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170919164122.gitefcfffc.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
(Example)
(Second run ovirt-engine-rename with different name)
1./usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
     --newname=ovirte1n.home.local \
     --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
     OVESETUP_CORE/engineStop=bool:'True' \
     OSETUP_RENAME/confirmForceOverwrite=bool:'False'"
2./usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
     --newname=ovirte2n.home.local \
     --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
     OVESETUP_CORE/engineStop=bool:'True' \
     OSETUP_RENAME/confirmForceOverwrite=bool:'False'"

Actual results:
# /usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
>      --newname=ovirte2n.home.local \
>      --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
>      OVESETUP_CORE/engineStop=bool:'True' \
>      OSETUP_RENAME/confirmForceOverwrite=bool:'False'"
[ INFO  ] Stage: Initializing
         
          .
          .
          .
          .

[ INFO  ] Stage: Environment customization
[ ERROR ] Host name is not valid: ovirte1n.home.local did not resolve into an IP address
[ ERROR ] Failed to execute stage 'Environment customization': Host name is not valid: ovirte1n.home.local did not resolve into an IP address
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-rename-20170921105022-63pemw.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20170921105022-rename.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of rename failed

Expected results:
Rename should either not pass for invalid hostname or it should be possible to recover when invalid hostname is entered.

Comment 1 Yedidyah Bar David 2017-09-24 06:33:06 UTC
(In reply to David Necpal from comment #0)
> Description of problem:
> After using ovirt-engine-rename and change hostname, it is not possible to
> use ovirt-engine-rename again because of error: "Host name is not
> valid:...". 
> 
> Version-Release number of selected component (if applicable):
> ovirt-engine-4.2.0-0.0.master.20170919164122.gitefcfffc.el7.centos.noarch
> 
> How reproducible:
> 100%
> 
> Steps to Reproduce:
> (Example)
> (Second run ovirt-engine-rename with different name)
> 1./usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
>      --newname=ovirte1n.home.local \
>      --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
>      OVESETUP_CORE/engineStop=bool:'True' \
>      OSETUP_RENAME/confirmForceOverwrite=bool:'False'"
> 2./usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
>      --newname=ovirte2n.home.local \
>      --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
>      OVESETUP_CORE/engineStop=bool:'True' \
>      OSETUP_RENAME/confirmForceOverwrite=bool:'False'"
> 
> Actual results:
> # /usr/share/ovirt-engine/setup/bin/ovirt-engine-rename \
> >      --newname=ovirte2n.home.local \
> >      --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' \
> >      OVESETUP_CORE/engineStop=bool:'True' \
> >      OSETUP_RENAME/confirmForceOverwrite=bool:'False'"
> [ INFO  ] Stage: Initializing
>          
>           .
>           .
>           .
>           .
> 
> [ INFO  ] Stage: Environment customization
> [ ERROR ] Host name is not valid: ovirte1n.home.local did not resolve into
> an IP address
> [ ERROR ] Failed to execute stage 'Environment customization': Host name is
> not valid: ovirte1n.home.local did not resolve into an IP address
> [ INFO  ] Stage: Clean up
>           Log file is located at
> /var/log/ovirt-engine/setup/ovirt-engine-rename-20170921105022-63pemw.log
> [ INFO  ] Generating answer file
> '/var/lib/ovirt-engine/setup/answers/20170921105022-rename.conf'
> [ INFO  ] Stage: Pre-termination
> [ INFO  ] Stage: Termination
> [ ERROR ] Execution of rename failed
> 
> Expected results:
> Rename should either not pass for invalid hostname

Indeed, see bug 1378352.

> or it should be possible
> to recover when invalid hostname is entered.

Indeed, although less important, see bug 1377758.

Closing as duplicate although the other bug only states 'empty string'. Obviously, the validation we'll add should be identical to that of an interactive run.

*** This bug has been marked as a duplicate of bug 1377758 ***