Bug 1494218 - go-colorable test failure
Summary: go-colorable test failure
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: golang-github-mattn-go-colorable
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Runge
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-21 17:27 UTC by Ed Marshall
Modified: 2017-10-17 00:12 UTC (History)
1 user (show)

Fixed In Version: golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc27
Clone Of:
Environment:
Last Closed: 2017-10-17 00:12:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ed Marshall 2017-09-21 17:27:43 UTC
It looks like golang-github-mattn-go-colorable-devel might be missing a BuildRequires for golang-github-mattn-go-isatty, judging by the koji failure I'm getting with the tests for golang-github-mgutz-ansi:

+ GOPATH=/builddir/build/BUILDROOT/golang-github-mgutz-ansi-0-0.1.20170206git9520e82.fc28.x86_64//usr/share/gocode:/usr/share/gocode
+ go test -compiler gc -ldflags '' github.com/mgutz/ansi
/usr/share/gocode/src/github.com/mattn/go-colorable/colorable_others.go:10:2: cannot find package "github.com/mattn/go-isatty" in any of:
	/usr/lib/golang/src/github.com/mattn/go-isatty (from $GOROOT)
	/builddir/build/BUILDROOT/golang-github-mgutz-ansi-0-0.1.20170206git9520e82.fc28.x86_64/usr/share/gocode/src/github.com/mattn/go-isatty (from $GOPATH)
	/usr/share/gocode/src/github.com/mattn/go-isatty

FWIW, when I ran gofed against go-colorable a while back, it ended up generating this for the -devel pacakage for me:

%if 0%{?with_check} && ! 0%{?with_bundled}
BuildRequires: golang(github.com/mattn/go-isatty)
%endif

Requires:      golang(github.com/mattn/go-isatty)

Might be worth a quick comparison of current gofed output to the spec you have now, to see if anything else is needed?

(And sorry to be picking these issues off one at a time like this. :( I know it's not ideal.)

Comment 1 Fedora Update System 2017-09-22 08:39:17 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

Comment 2 Matthias Runge 2017-09-22 08:41:09 UTC
(In reply to Ed Marshall from comment #0)

> 
> Might be worth a quick comparison of current gofed output to the spec you
> have now, to see if anything else is needed?
> 
> (And sorry to be picking these issues off one at a time like this. :( I know
> it's not ideal.)

Thank you for your suggestion. I just did that and submitted a new build.

I'm sorry for delivering piece by piece here. It's just one of many packages I'd require for grafana, thus I haven't been able to test it with it yet.

Comment 3 Fedora Update System 2017-09-23 00:28:03 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

Comment 4 Ed Marshall 2017-09-23 20:09:55 UTC
You have my deepest sympathies for trying to get Grafana packaged. ;) (I took an interest in a few of these packages because I'd like to get Vault packaged up, which has a similarly lengthy dependency graph.)

This update looks good; I was finally able to get a scratch build of golang-github-mgutz-ansi!

Comment 5 Fedora Update System 2017-10-04 22:21:27 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2017-10-06 07:35:32 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6fad013993

Comment 7 Fedora Update System 2017-10-06 22:26:06 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6fad013993

Comment 8 Fedora Update System 2017-10-17 00:12:43 UTC
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.